Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1042933002: ServiceWorker: Support non-window clients in Clients.matchAll (1/2 chromium) (Closed)

Created:
5 years, 8 months ago by kinuko
Modified:
5 years, 8 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+watch, kinuko+serviceworker, michaeln, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, nhiroki, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Support non-window clients in Clients.matchAll (1/2 chromium) - Change ServiceWorkerVersion::OnGetClients to also return non-window clients if ClientQueryOptions specifies non-default/non-window client type Blink-side patch: https://codereview.chromium.org/1040993003/ BUG=460415 TEST=to be added in blink Committed: https://crrev.com/abac151b1992a2f9d8843ff0efa46888ddd636ba Cr-Commit-Position: refs/heads/master@{#323008}

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -157 lines) Patch
M content/browser/service_worker/service_worker_context_core.cc View 1 chunk +1 line, -1 line 2 comments Download
M content/browser/service_worker/service_worker_context_request_handler_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host_unittest.cc View 5 chunks +14 lines, -26 lines 0 comments Download
M content/browser/service_worker/service_worker_handle_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_job_unittest.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.h View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host.cc View 6 chunks +28 lines, -11 lines 0 comments Download
M content/browser/service_worker/service_worker_provider_host_unittest.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_request_handler_unittest.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_storage_unittest.cc View 3 chunks +12 lines, -21 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job_unittest.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 2 chunks +10 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 6 chunks +103 lines, -39 lines 5 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc View 1 chunk +2 lines, -6 lines 0 comments Download
M content/common/service_worker/service_worker_types.h View 1 chunk +4 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M content/renderer/shared_worker/embedded_shared_worker_stub.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
kinuko
PTL
5 years, 8 months ago (2015-03-30 18:02:05 UTC) #2
falken
lgtm https://codereview.chromium.org/1042933002/diff/1/content/browser/service_worker/service_worker_context_core.cc File content/browser/service_worker/service_worker_context_core.cc (right): https://codereview.chromium.org/1042933002/diff/1/content/browser/service_worker/service_worker_context_core.cc#newcode51 content/browser/service_worker/service_worker_context_core.cc:51: return host->provider_type() != SERVICE_WORKER_PROVIDER_FOR_CONTROLLER && Would it make ...
5 years, 8 months ago (2015-03-31 03:39:48 UTC) #3
nhiroki
LGTM! https://codereview.chromium.org/1042933002/diff/1/content/browser/service_worker/service_worker_version.cc File content/browser/service_worker/service_worker_version.cc (right): https://codereview.chromium.org/1042933002/diff/1/content/browser/service_worker/service_worker_version.cc#newcode309 content/browser/service_worker/service_worker_version.cc:309: continue; Oh... |callback| was gone... good catch!
5 years, 8 months ago (2015-03-31 05:26:34 UTC) #4
nhiroki
+jochen@, can you review content/renderer/* as an OWNER? I'll take over this CL from kinuko@ ...
5 years, 8 months ago (2015-03-31 05:49:37 UTC) #6
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-03-31 10:32:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1042933002/1
5 years, 8 months ago (2015-03-31 10:51:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-31 10:55:37 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/abac151b1992a2f9d8843ff0efa46888ddd636ba Cr-Commit-Position: refs/heads/master@{#323008}
5 years, 8 months ago (2015-03-31 10:56:41 UTC) #11
nhiroki
5 years, 8 months ago (2015-04-01 00:50:53 UTC) #12
Message was sent while issue was closed. 
Uploaded a follow-up CL: https://codereview.chromium.org/1050733002/

https://codereview.chromium.org/1042933002/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_context_core.cc (right):

https://codereview.chromium.org/1042933002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_context_core.cc:51: return
host->provider_type() != SERVICE_WORKER_PROVIDER_FOR_CONTROLLER &&
On 2015/03/31 03:39:48, falken wrote:
> Would it make sense to have a bool IsProviderForClient(provider_type)
somewhere
> so we don't test "not CONTROLLER" in many places? It would also handle UNKNOWN
> correctly.

Done in https://codereview.chromium.org/1050733002/

https://codereview.chromium.org/1042933002/diff/1/content/browser/service_wor...
File content/browser/service_worker/service_worker_version.cc (right):

https://codereview.chromium.org/1042933002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_version.cc:1523:
TRACE_EVENT0("ServiceWorker", "ServiceWorkerVersion::GetWindowClients");
On 2015/03/31 03:39:48, falken wrote:
> Should this trace span to DidGetWindowClients?

Done in https://codereview.chromium.org/1050733002/

https://codereview.chromium.org/1042933002/diff/1/content/browser/service_wor...
content/browser/service_worker/service_worker_version.cc:1525: // 4.3.1
matchAll(options)
On 2015/03/31 03:39:48, falken wrote:
> FYI I've given up on putting spec section numbers since they get stale really
> fast.

Done in https://codereview.chromium.org/1050733002/

Powered by Google App Engine
This is Rietveld 408576698