content/browser/service_worker/service_worker_version_unittest.cc - Issue 1042933002: ServiceWorker: Support non-window clients in Clients.matchAll (1/2 chromium)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_version_unittest.cc

Issue 1042933002: ServiceWorker: Support non-window clients in Clients.matchAll (1/2 chromium) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_version.cc ('K') | « content/browser/service_worker/service_worker_version.cc ('k') | content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_version_unittest.cc

diff --git a/content/browser/service_worker/service_worker_version_unittest.cc b/content/browser/service_worker/service_worker_version_unittest.cc

index 5f3ec486a9fd9bf1a55a22af6a21daad6c6995cc..b79d240a9c1f586edb74ebeeab617a007a2291c9 100644

--- a/content/browser/service_worker/service_worker_version_unittest.cc

+++ b/content/browser/service_worker/service_worker_version_unittest.cc

@@ -446,13 +446,10 @@ TEST_F(ServiceWorkerVersionTest, IdleTimeout) {

// Adding a controllee resets the idle time.

version_->idle_time_ -= kOneSecond;

idle_time = version_->idle_time_;

- scoped_ptr<ServiceWorkerProviderHost> host(

- new ServiceWorkerProviderHost(33 /* dummy render process id */,

- MSG_ROUTING_NONE /* render_frame_id */,

- 1 /* dummy provider_id */,

- SERVICE_WORKER_PROVIDER_FOR_CONTROLLEE,

- helper_->context()->AsWeakPtr(),

- NULL));

+ scoped_ptr<ServiceWorkerProviderHost> host(new ServiceWorkerProviderHost(

+ 33 /* dummy render process id */, MSG_ROUTING_NONE /* render_frame_id */,

+ 1 /* dummy provider_id */, SERVICE_WORKER_PROVIDER_FOR_WINDOW,

+ helper_->context()->AsWeakPtr(), NULL));

version_->AddControllee(host.get());

EXPECT_TRUE(version_->timeout_timer_.IsRunning());

EXPECT_LT(idle_time, version_->idle_time_);