content/browser/service_worker/service_worker_context_core.cc - Issue 1042933002: ServiceWorker: Support non-window clients in Clients.matchAll (1/2 chromium)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_context_core.cc

Issue 1042933002: ServiceWorker: Support non-window clients in Clients.matchAll (1/2 chromium) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_context_request_handler_unittest.cc » ('j') | content/browser/service_worker/service_worker_version.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_context_core.cc

diff --git a/content/browser/service_worker/service_worker_context_core.cc b/content/browser/service_worker/service_worker_context_core.cc

index 376db13a90dd0354695fce9fc649a87515fccb47..a7196ce045114276c07994ede48a886ccca83241 100644

--- a/content/browser/service_worker/service_worker_context_core.cc

+++ b/content/browser/service_worker/service_worker_context_core.cc

@@ -48,7 +48,7 @@ void SuccessReportingCallback(

bool IsSameOriginClientProviderHost(const GURL& origin,

ServiceWorkerProviderHost* host) {

- return host->provider_type() == SERVICE_WORKER_PROVIDER_FOR_CONTROLLEE &&

+ return host->provider_type() != SERVICE_WORKER_PROVIDER_FOR_CONTROLLER &&

falken 2015/03/31 03:39:48 Would it make sense to have a bool IsProviderForCl

nhiroki 2015/04/01 00:50:53 Done in https://codereview.chromium.org/1050733002

host->document_url().GetOrigin() == origin;

}