content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc - Issue 1042933002: ServiceWorker: Support non-window clients in Clients.matchAll (1/2 chromium)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

Issue 1042933002: ServiceWorker: Support non-window clients in Clients.matchAll (1/2 chromium) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_version.cc ('K') | « content/browser/service_worker/service_worker_version_unittest.cc ('k') | content/common/service_worker/service_worker_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

diff --git a/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc b/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

index 01d8088df6f658bc1077ee5c7dcf599cde70b390..cd90d45f731150edf3217673b3d97d4d506b0dac 100644

--- a/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

+++ b/content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc

@@ -187,12 +187,8 @@ class ServiceWorkerWriteToCacheJobTest : public testing::Test {

// An empty host.

scoped_ptr<ServiceWorkerProviderHost> host(new ServiceWorkerProviderHost(

- kMockRenderProcessId,

- MSG_ROUTING_NONE,

- kMockProviderId,

- SERVICE_WORKER_PROVIDER_FOR_CONTROLLEE,

- context()->AsWeakPtr(),

- nullptr));

+ kMockRenderProcessId, MSG_ROUTING_NONE, kMockProviderId,

+ SERVICE_WORKER_PROVIDER_FOR_WINDOW, context()->AsWeakPtr(), nullptr));

provider_host_ = host->AsWeakPtr();

context()->AddProviderHost(host.Pass());

provider_host_->running_hosted_version_ = version_;