Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1042613002: Rename isDone() to hasFinishedLoading() for HTMLImport (Closed)

Created:
5 years, 8 months ago by hyunjunekim2
Modified:
5 years, 8 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, webcomponents-bugzilla_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rename isDone() to haveFinishedLoading() for HTMLImport This CL renames isDone() to haveFinishedLoading() for HTMLImport. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192902

Patch Set 1 #

Patch Set 2 : Change name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M Source/core/dom/custom/CustomElementScheduler.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/imports/HTMLImport.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/imports/HTMLImportChild.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/imports/HTMLImportChild.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/imports/HTMLImportStateResolver.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/imports/HTMLImportTreeRoot.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/imports/HTMLImportTreeRoot.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/imports/LinkImport.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
hyunjunekim2
Hi, I'm hyunjunekim (hyunjune.kim@samsung.com, hykim0777@gamil.com). I fixed up. Could you check this one? Thank you.
5 years, 8 months ago (2015-03-28 13:39:21 UTC) #2
Mike West
I'm fine with renaming the method (though `haveFinishedLoading` sounds awkward; I'd suggest something like `hasFinishedLoading`, ...
5 years, 8 months ago (2015-03-30 04:55:34 UTC) #5
hyunjunekim2
On 2015/03/30 04:55:34, Mike West wrote: > I'm fine with renaming the method (though `haveFinishedLoading` ...
5 years, 8 months ago (2015-03-30 07:09:49 UTC) #6
hyunjunekim2
> > I'd suggest something like `hasFinishedLoading`, though it's not clear to me > > ...
5 years, 8 months ago (2015-03-30 08:49:18 UTC) #7
Mike West
LGTM, but I'll defer to morrita@, who has a deeper relationship with this code than ...
5 years, 8 months ago (2015-03-30 08:59:29 UTC) #9
hyunjunekim2
Morrita, Hello, I'm hyunjunekim (hyunjune.kim@samsung.com, hykim0777@gamil.com). Could you give me a review? Thank you.
5 years, 8 months ago (2015-03-31 01:30:28 UTC) #10
Hajime Morrita
lgtm
5 years, 8 months ago (2015-03-31 17:10:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1042613002/20001
5 years, 8 months ago (2015-04-01 01:59:01 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 04:04:58 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192902

Powered by Google App Engine
This is Rietveld 408576698