Source/core/html/imports/LinkImport.cpp - Issue 1042613002: Rename isDone() to hasFinishedLoading() for HTMLImport

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/imports/LinkImport.cpp

Issue 1042613002: Rename isDone() to hasFinishedLoading() for HTMLImport (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Change name. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/imports/LinkImport.cpp

diff --git a/Source/core/html/imports/LinkImport.cpp b/Source/core/html/imports/LinkImport.cpp

index f17da74aa75b9b8c8f267200647ed82f4f0886a7..3a3e629e9812eac13882fd23e80eef820c7b98d6 100644

--- a/Source/core/html/imports/LinkImport.cpp

+++ b/Source/core/html/imports/LinkImport.cpp

@@ -130,7 +130,7 @@ bool LinkImport::hasLoaded() const

{

// Should never be called after importChildWasDestroyed was called.

ASSERT(m_owner);

- return m_child && m_child->isDone() && !m_child->loader()->hasError();

+ return m_child && m_child->hasFinishedLoading() && !m_child->loader()->hasError();

}

void LinkImport::ownerInserted()

« no previous file with comments | « Source/core/html/imports/HTMLImportTreeRoot.cpp ('k') | no next file » | no next file with comments »