Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1035583002: Update 4-at-a-time APIs. (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update 4-at-a-time APIs. There is no reason to require the 4 SkPMFloats (registers) to be adjacent. The only potential win in loads and stores comes from the SkPMColors being adjacent. Makes no difference to existing bench. BUG=skia: Committed: https://skia.googlesource.com/skia/+/15391ee4acaa092f52742f64968ad8046b74ca81

Patch Set 1 #

Patch Set 2 : redo #

Patch Set 3 : abcd #

Patch Set 4 : (C) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -48 lines) Patch
M bench/PMFloatBench.cpp View 1 2 3 2 chunks +27 lines, -9 lines 0 comments Download
M src/core/SkPMFloat.h View 1 2 3 3 chunks +12 lines, -3 lines 0 comments Download
M src/opts/SkPMFloat_SSE2.h View 1 2 3 2 chunks +24 lines, -11 lines 0 comments Download
M src/opts/SkPMFloat_SSSE3.h View 1 2 3 2 chunks +28 lines, -10 lines 0 comments Download
M src/opts/SkPMFloat_neon.h View 1 2 3 2 chunks +27 lines, -6 lines 0 comments Download
M src/opts/SkPMFloat_none.h View 1 2 3 2 chunks +27 lines, -6 lines 0 comments Download
M tests/PMFloatTest.cpp View 1 2 3 2 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
mtklein_C
5 years, 9 months ago (2015-03-24 21:42:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035583002/40001
5 years, 9 months ago (2015-03-24 21:42:54 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-24 21:42:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/87)
5 years, 9 months ago (2015-03-24 21:49:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035583002/40001
5 years, 9 months ago (2015-03-24 22:30:18 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-24 22:30:19 UTC) #10
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 9 months ago (2015-03-25 04:30:22 UTC) #12
reed1
lgtm
5 years, 9 months ago (2015-03-25 20:20:45 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035583002/40001
5 years, 9 months ago (2015-03-25 20:23:37 UTC) #15
commit-bot: I haz the power
Presubmit check for 1035583002-40001 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 9 months ago (2015-03-25 20:23:44 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1035583002/60001
5 years, 9 months ago (2015-03-25 20:27:00 UTC) #20
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 20:43:37 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/15391ee4acaa092f52742f64968ad8046b74ca81

Powered by Google App Engine
This is Rietveld 408576698