Change a bool type to an enum type in constructor argument of SpaceSplitString.

This CL is refactoring code.Replace a bool type with an enum type in constructor argument of SpaceSplitString.

R=mkwst@chromium.org, fs@opera.com

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192657

[hyunjunekim2, 2015-03-26 16:52:07]

hyunjune.kim@samsung.com changed reviewers:
+ fs@opera.com, mkwst@chromium.org

[hyunjunekim2, 2015-03-26 16:55:11]

Hi, I'm hyunjunekim (hyunjune.kim@samsung.com, hykim0777@gamil.com). I replace a
bool type with an enum type in constructor argument of SpaceSplitString. Could
you get me review about this code?

[Mike West, 2015-03-26 19:33:05]

Thanks for following up on this.

https://codereview.chromium.org/1035573005/diff/20001/Source/core/dom/SpaceSp...
File Source/core/dom/SpaceSplitString.cpp (right):

https://codereview.chromium.org/1035573005/diff/20001/Source/core/dom/SpaceSp...
Source/core/dom/SpaceSplitString.cpp:162: if ((splitStringCase ==
ShouldFoldCase) && hasNonASCIIOrUpper(string))
Nit: You don't need the extra () here.

https://codereview.chromium.org/1035573005/diff/20001/Source/core/dom/SpaceSp...
File Source/core/dom/SpaceSplitString.h (right):

https://codereview.chromium.org/1035573005/diff/20001/Source/core/dom/SpaceSp...
Source/core/dom/SpaceSplitString.h:30: enum SplitStringCase {
I'd prefer you to move this into SpaceSplitString rather than adding it to the
global 'blink::' namespace. Perhaps `SpaceSplitString::CaseFolding`?

[hyunjunekim2, 2015-03-27 02:00:06]

On 2015/03/26 19:33:05, Mike West wrote:
> Thanks for following up on this.
> 
>
https://codereview.chromium.org/1035573005/diff/20001/Source/core/dom/SpaceSp...
> File Source/core/dom/SpaceSplitString.cpp (right):
> 
>
https://codereview.chromium.org/1035573005/diff/20001/Source/core/dom/SpaceSp...
> Source/core/dom/SpaceSplitString.cpp:162: if ((splitStringCase ==
> ShouldFoldCase) && hasNonASCIIOrUpper(string))
> Nit: You don't need the extra () here.
> 
>
https://codereview.chromium.org/1035573005/diff/20001/Source/core/dom/SpaceSp...
> File Source/core/dom/SpaceSplitString.h (right):
> 
>
https://codereview.chromium.org/1035573005/diff/20001/Source/core/dom/SpaceSp...
> Source/core/dom/SpaceSplitString.h:30: enum SplitStringCase {
> I'd prefer you to move this into SpaceSplitString rather than adding it to the
> global 'blink::' namespace. Perhaps `SpaceSplitString::CaseFolding`?

@Mike West
I modified for your feedback. Could you check it? Thank you.

[Mike West, 2015-03-27 04:58:01]

LGTM, thanks!

[hyunjunekim2, 2015-03-27 05:26:44]

On 2015/03/27 04:58:01, Mike West wrote:
> LGTM, thanks!

@ Mike West
If be other issues, i can get you my hands. I'm so happy for contributing. 
Thank you. :)

[hyunjunekim2, 2015-03-27 06:18:45]

@ Mike West
Could you run try-bot for this issue? and commit-bot?
Thank you.

[Mike West, 2015-03-27 06:24:15]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2015-03-27 06:24:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1035573005/40001

[commit-bot: I haz the power, 2015-03-27 07:57:20]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192657