Source/core/dom/ElementData.h - Issue 1035573005: Change a bool type to an enum type in constructor argument of SpaceSplitString.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/ElementData.h

Issue 1035573005: Change a bool type to an enum type in constructor argument of SpaceSplitString. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Move enum struct to SpaceSplitString and rename. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/ElementData.h

diff --git a/Source/core/dom/ElementData.h b/Source/core/dom/ElementData.h

index 1c6a5d1756b0a6098d670b5e94ca1e6cb725c4ae..3399df2850f1a5dba96c480a91c3723f25cf7bef 100644

--- a/Source/core/dom/ElementData.h

+++ b/Source/core/dom/ElementData.h

@@ -60,7 +60,7 @@ public:

#endif

void clearClass() const { m_classNames.clear(); }

- void setClass(const AtomicString& className, bool shouldFoldCase) const { m_classNames.set(className, shouldFoldCase); }

+ void setClass(const AtomicString& className, bool shouldFoldCase) const { m_classNames.set(className, shouldFoldCase ? SpaceSplitString::ShouldFoldCase : SpaceSplitString::ShouldNotFoldCase); }

const SpaceSplitString& classNames() const { return m_classNames; }

const AtomicString& idForStyleResolution() const { return m_idForStyleResolution; }

« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/dom/SandboxFlags.cpp » ('j') | no next file with comments »