Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: Source/core/page/EventHandler.cpp

Issue 1035573005: Change a bool type to an enum type in constructor argument of SpaceSplitString. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Move enum struct to SpaceSplitString and rename. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLAnchorElement.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserv ed. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserv ed.
3 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org) 3 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
4 * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies) 4 * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies)
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 1662 matching lines...) Expand 10 before | Expand all | Expand 10 after
1673 bool matched = false; 1673 bool matched = false;
1674 AtomicString dropZoneStr = element->fastGetAttribute(webkitdropzoneAttr) ; 1674 AtomicString dropZoneStr = element->fastGetAttribute(webkitdropzoneAttr) ;
1675 1675
1676 if (dropZoneStr.isEmpty()) 1676 if (dropZoneStr.isEmpty())
1677 continue; 1677 continue;
1678 1678
1679 UseCounter::count(element->document(), UseCounter::PrefixedHTMLElementDr opzone); 1679 UseCounter::count(element->document(), UseCounter::PrefixedHTMLElementDr opzone);
1680 1680
1681 dropZoneStr = dropZoneStr.lower(); 1681 dropZoneStr = dropZoneStr.lower();
1682 1682
1683 SpaceSplitString keywords(dropZoneStr, false); 1683 SpaceSplitString keywords(dropZoneStr, SpaceSplitString::ShouldNotFoldCa se);
1684 if (keywords.isNull()) 1684 if (keywords.isNull())
1685 continue; 1685 continue;
1686 1686
1687 DragOperation dragOperation = DragOperationNone; 1687 DragOperation dragOperation = DragOperationNone;
1688 for (unsigned i = 0; i < keywords.size(); i++) { 1688 for (unsigned i = 0; i < keywords.size(); i++) {
1689 DragOperation op = convertDropZoneOperationToDragOperation(keywords[ i]); 1689 DragOperation op = convertDropZoneOperationToDragOperation(keywords[ i]);
1690 if (op != DragOperationNone) { 1690 if (op != DragOperationNone) {
1691 if (dragOperation == DragOperationNone) 1691 if (dragOperation == DragOperationNone)
1692 dragOperation = op; 1692 dragOperation = op;
1693 } else { 1693 } else {
(...skipping 2253 matching lines...) Expand 10 before | Expand all | Expand 10 after
3947 3947
3948 // If it's in the direction to hide the top controls, only consume when the frame can also scroll. 3948 // If it's in the direction to hide the top controls, only consume when the frame can also scroll.
3949 if (m_frame->view()->scrollPosition().y() < m_frame->view()->maximumScrollPo sition().y()) 3949 if (m_frame->view()->scrollPosition().y() < m_frame->view()->maximumScrollPo sition().y())
3950 return true; 3950 return true;
3951 3951
3952 return false; 3952 return false;
3953 } 3953 }
3954 3954
3955 3955
3956 } // namespace blink 3956 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/html/HTMLAnchorElement.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698