Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: Source/core/dom/Element.cpp

Issue 1035573005: Change a bool type to an enum type in constructor argument of SpaceSplitString. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Move enum struct to SpaceSplitString and rename. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/DOMSettableTokenList.cpp ('k') | Source/core/dom/ElementData.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1173 matching lines...) Expand 10 before | Expand all | Expand 10 after
1184 if (!oldId.isEmpty() && featureSet.hasSelectorForId(oldId)) 1184 if (!oldId.isEmpty() && featureSet.hasSelectorForId(oldId))
1185 return true; 1185 return true;
1186 if (!newId.isEmpty() && featureSet.hasSelectorForId(newId)) 1186 if (!newId.isEmpty() && featureSet.hasSelectorForId(newId))
1187 return true; 1187 return true;
1188 } 1188 }
1189 } 1189 }
1190 1190
1191 if (name == HTMLNames::classAttr) { 1191 if (name == HTMLNames::classAttr) {
1192 const AtomicString& newClassString = newValue; 1192 const AtomicString& newClassString = newValue;
1193 if (classStringHasClassName(newClassString)) { 1193 if (classStringHasClassName(newClassString)) {
1194 const bool shouldFoldCase = document().inQuirksMode();
1195 const SpaceSplitString& oldClasses = elementData()->classNames(); 1194 const SpaceSplitString& oldClasses = elementData()->classNames();
1196 const SpaceSplitString newClasses(newClassString, shouldFoldCase); 1195 const SpaceSplitString newClasses(newClassString, document().inQuirk sMode() ? SpaceSplitString::ShouldFoldCase : SpaceSplitString::ShouldNotFoldCase );
1197 if (featureSet.checkSelectorsForClassChange(oldClasses, newClasses)) 1196 if (featureSet.checkSelectorsForClassChange(oldClasses, newClasses))
1198 return true; 1197 return true;
1199 } else { 1198 } else {
1200 const SpaceSplitString& oldClasses = elementData()->classNames(); 1199 const SpaceSplitString& oldClasses = elementData()->classNames();
1201 if (featureSet.checkSelectorsForClassChange(oldClasses)) 1200 if (featureSet.checkSelectorsForClassChange(oldClasses))
1202 return true; 1201 return true;
1203 } 1202 }
1204 } 1203 }
1205 1204
1206 return featureSet.hasSelectorForAttribute(name.localName()); 1205 return featureSet.hasSelectorForAttribute(name.localName());
(...skipping 2180 matching lines...) Expand 10 before | Expand all | Expand 10 after
3387 { 3386 {
3388 #if ENABLE(OILPAN) 3387 #if ENABLE(OILPAN)
3389 if (hasRareData()) 3388 if (hasRareData())
3390 visitor->trace(elementRareData()); 3389 visitor->trace(elementRareData());
3391 visitor->trace(m_elementData); 3390 visitor->trace(m_elementData);
3392 #endif 3391 #endif
3393 ContainerNode::trace(visitor); 3392 ContainerNode::trace(visitor);
3394 } 3393 }
3395 3394
3396 } // namespace blink 3395 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/dom/DOMSettableTokenList.cpp ('k') | Source/core/dom/ElementData.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698