Issue 1030743003: Revert of impl colormatrix w/ floats

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1030743003: Revert of impl colormatrix w/ floats (Closed)

Created:
5 years, 9 months ago by reed2

Modified:
5 years, 9 months ago

Reviewers:
mtklein, caryclark, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of impl colormatrix w/ floats (patchset #7 id:120001 of https://codereview.chromium.org/967943002/) Reason for revert: Arm64 seems to be having glitches :( See gm:colormatrix on Arm64/TegraK1/Nexus9 last square should be all white, but it has stripes Original issue's description: > impl colormatrix w/ floats > > this needs to land first https://codereview.chromium.org/1031713003 > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/7971def11be91ed08eae7107b372322d24e67544 TBR=mtklein@google.com,caryclark@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/374a4c3b744e8c77455efa73b139950136f7b374

Created: 5 years, 9 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+39 lines, -139 lines)			Patch
M	gm/colormatrix.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	include/effects/SkColorMatrix.h	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	include/effects/SkColorMatrixFilter.h	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	src/effects/SkColorMatrixFilter.cpp	View	4 chunks	+36 lines, -133 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1030743003/1

5 years, 9 months ago (2015-03-24 01:52:51 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-24 01:53:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/374a4c3b744e8c77455efa73b139950136f7b374