Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 967943002: impl colormatrix w/ floats (Closed)

Created:
5 years, 9 months ago by reed1
Modified:
5 years, 9 months ago
Reviewers:
mtklein, caryclark
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : use SK_SUPPORT_LEGACY_INT_COLORMATRIX flag" #

Total comments: 6

Patch Set 4 : now with 1/255 - ULP #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -35 lines) Patch
M gm/colormatrix.cpp View 1 1 chunk +0 lines, -1 line 0 comments Download
M include/effects/SkColorMatrix.h View 1 2 3 4 5 1 chunk +4 lines, -1 line 0 comments Download
M include/effects/SkColorMatrixFilter.h View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 2 3 4 5 6 4 chunks +129 lines, -32 lines 0 comments Download

Messages

Total messages: 28 (13 generated)
reed1
5 years, 9 months ago (2015-03-23 18:46:40 UTC) #2
caryclark
lgtm https://codereview.chromium.org/967943002/diff/40001/include/effects/SkColorMatrixFilter.h File include/effects/SkColorMatrixFilter.h (right): https://codereview.chromium.org/967943002/diff/40001/include/effects/SkColorMatrixFilter.h#newcode50 include/effects/SkColorMatrixFilter.h:50: float fTranspose[20]; // for Sk4f could this be ...
5 years, 9 months ago (2015-03-23 19:02:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967943002/40001
5 years, 9 months ago (2015-03-23 19:14:59 UTC) #6
reed1
ptal https://codereview.chromium.org/967943002/diff/40001/include/effects/SkColorMatrixFilter.h File include/effects/SkColorMatrixFilter.h (right): https://codereview.chromium.org/967943002/diff/40001/include/effects/SkColorMatrixFilter.h#newcode50 include/effects/SkColorMatrixFilter.h:50: float fTranspose[20]; // for Sk4f On 2015/03/23 19:02:48, ...
5 years, 9 months ago (2015-03-23 20:11:05 UTC) #7
caryclark
lgtm
5 years, 9 months ago (2015-03-23 20:15:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967943002/60001
5 years, 9 months ago (2015-03-23 20:33:43 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/55)
5 years, 9 months ago (2015-03-23 20:43:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967943002/80001
5 years, 9 months ago (2015-03-23 21:08:31 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/57)
5 years, 9 months ago (2015-03-23 21:12:11 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967943002/100001
5 years, 9 months ago (2015-03-23 21:16:45 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/59)
5 years, 9 months ago (2015-03-23 21:20:31 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/967943002/120001
5 years, 9 months ago (2015-03-23 21:30:31 UTC) #25
commit-bot: I haz the power
Committed patchset #7 (id:120001) as https://skia.googlesource.com/skia/+/7971def11be91ed08eae7107b372322d24e67544
5 years, 9 months ago (2015-03-23 21:35:29 UTC) #26
reed2
A revert of this CL (patchset #7 id:120001) has been created in https://codereview.chromium.org/1030743003/ by reed@chromium.org. ...
5 years, 9 months ago (2015-03-24 01:52:44 UTC) #27
mtklein
5 years, 9 months ago (2015-03-24 01:55:22 UTC) #28
Message was sent while issue was closed. 
On 2015/03/24 01:52:44, reed2 wrote:
> A revert of this CL (patchset #7 id:120001) has been created in
> https://codereview.chromium.org/1030743003/ by mailto:reed@chromium.org.
> 
> The reason for reverting is: Arm64 seems to be having glitches :(
> 
> See gm:colormatrix on Arm64/TegraK1/Nexus9
> 
> last square should be all white, but it has stripes.

Yeah, it really does.  Looked at a bunch of these... Nexus 9 looks more wrong
than right.

Powered by Google App Engine
This is Rietveld 408576698