Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 102993018: Remove UTF string conversion functions from the global namespace. (Closed)

Created:
6 years, 12 months ago by Avi (use Gerrit)
Modified:
6 years, 12 months ago
CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, dyu1, benquan, tfarina, Paweł Hajdan Jr., haitaol+watch_chromium.org, jam, joi+watch-content_chromium.org, robertshield, Dane Wallinga, browser-components-watch_chromium.org, darin-cc_chromium.org, rouslan+autofillwatch_chromium.org, estade+watch_chromium.org, erikwright+watch_chromium.org, Ilya Sherman, jshin+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Remove UTF string conversion functions from the global namespace. BUG=330556 TEST=no change TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242519

Patch Set 1 #

Patch Set 2 : fixin' #

Patch Set 3 : fix too #

Patch Set 4 : fixed yet? #

Patch Set 5 : fiiiiiiix? #

Patch Set 6 : it's 12:40 am #

Patch Set 7 : aaaaaaaaaa #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -90 lines) Patch
M base/command_line.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M base/command_line_unittest.cc View 1 1 chunk +8 lines, -4 lines 0 comments Download
M base/i18n/file_util_icu.cc View 1 1 chunk +6 lines, -4 lines 0 comments Download
M base/i18n/file_util_icu_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/logging.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M base/strings/string_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/strings/utf_string_conversions.h View 1 2 2 chunks +7 lines, -22 lines 0 comments Download
M base/test/test_file_util_posix.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 4 5 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/importer/firefox_importer_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/importer/importer_unittest_utils.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_sync_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_change_processor.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 1 2 3 4 5 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/find_bar/find_bar_host_browsertest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/external_protocol_dialog.cc View 1 2 3 4 5 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/website_settings/website_settings.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/webdata/autofill_profile_syncable_service.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/renderer/autofill/password_autofill_agent_browsertest.cc View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider_hunspell_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/automation/tab_proxy.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/form_field_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/policy_loader_win_unittest.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/zlib/google/zip_internal.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/zlib/google/zip_reader.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gfx/render_text_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/text_elider_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/corewm/tooltip_aura_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/examples/label_example.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/examples/textfield_example.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/touchui/touch_selection_controller_impl_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/view_unittest.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/browser/database/database_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/database/database_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/database/databases_table_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/child/ftp_directory_listing_response_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/database/database_connections_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/webpreferences.cc View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Avi (use Gerrit)
6 years, 12 months ago (2013-12-26 07:08:01 UTC) #1
Message was sent while issue was closed. 
Committed patchset #7 manually as r242519.

Powered by Google App Engine
This is Rietveld 408576698