Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2704)

Unified Diff: chrome/browser/sync/profile_sync_service_bookmark_unittest.cc

Issue 102993018: Remove UTF string conversion functions from the global namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: aaaaaaaaaa Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/profile_sync_service_bookmark_unittest.cc
diff --git a/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc b/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc
index c8e7be8016d486ce0dd93f3df5f7aea6c8f3a523..79c6b6487a5ef8ca2f862105bec4afa4f558e87a 100644
--- a/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc
+++ b/chrome/browser/sync/profile_sync_service_bookmark_unittest.cc
@@ -654,7 +654,7 @@ class ProfileSyncServiceBookmarkTest : public testing::Test {
const BookmarkNode* bnode =
model_associator_->GetChromeNodeFromSyncId(sync_id);
ASSERT_TRUE(bnode);
- EXPECT_EQ(bnode->GetTitle(), WideToUTF16Hack(title));
+ EXPECT_EQ(bnode->GetTitle(), base::WideToUTF16Hack(title));
}
void ExpectBrowserNodeURL(int64 sync_id, const std::string& url) {
@@ -1430,10 +1430,10 @@ void ProfileSyncServiceBookmarkTestWithData::PopulateFromTestData(
if (item.url) {
const base::Time add_time =
start_time_ + base::TimeDelta::FromMinutes(*running_count);
- model_->AddURLWithCreationTime(node, i, WideToUTF16Hack(item.title),
+ model_->AddURLWithCreationTime(node, i, base::WideToUTF16Hack(item.title),
GURL(item.url), add_time);
} else {
- model_->AddFolder(node, i, WideToUTF16Hack(item.title));
+ model_->AddFolder(node, i, base::WideToUTF16Hack(item.title));
}
(*running_count)++;
}
@@ -1453,7 +1453,7 @@ void ProfileSyncServiceBookmarkTestWithData::CompareWithTestData(
const TestData& item = data[i];
GURL url = GURL(item.url == NULL ? "" : item.url);
BookmarkNode test_node(url);
- test_node.SetTitle(WideToUTF16Hack(item.title));
+ test_node.SetTitle(base::WideToUTF16Hack(item.title));
EXPECT_EQ(child_node->GetTitle(), test_node.GetTitle());
if (item.url) {
EXPECT_FALSE(child_node->is_folder());
@@ -1895,7 +1895,7 @@ TEST_F(ProfileSyncServiceBookmarkTestWithData, UpdateDateAdded) {
const BookmarkNode* node = model_->bookmark_bar_node()->GetChild(0);
ASSERT_TRUE(node);
EXPECT_TRUE(node->is_url());
- EXPECT_EQ(WideToUTF16Hack(kTitle), node->GetTitle());
+ EXPECT_EQ(base::WideToUTF16Hack(kTitle), node->GetTitle());
EXPECT_EQ(kUrl, node->url().possibly_invalid_spec());
EXPECT_EQ(node->date_added(), base::Time::FromInternalValue(30));
}
@@ -2061,7 +2061,7 @@ TEST_F(ProfileSyncServiceBookmarkTestWithData, UpdateTransactionVersion) {
// versions of others remain same.
const BookmarkNode* changed_bookmark =
model_->bookmark_bar_node()->GetChild(0);
- model_->SetTitle(changed_bookmark, WideToUTF16Hack(L"test"));
+ model_->SetTitle(changed_bookmark, base::ASCIIToUTF16("test"));
base::MessageLoop::current()->RunUntilIdle();
GetTransactionVersions(model_->root_node(), &new_versions);
EXPECT_EQ(initial_versions[model_->root_node()->id()] + 2,
« no previous file with comments | « chrome/browser/sync/glue/bookmark_change_processor.cc ('k') | chrome/browser/ui/find_bar/find_bar_host_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698