Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Side by Side Diff: base/strings/utf_string_conversions.h

Issue 102993018: Remove UTF string conversion functions from the global namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: aaaaaaaaaa Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/strings/string_util.cc ('k') | base/test/test_file_util_posix.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_STRINGS_UTF_STRING_CONVERSIONS_H_ 5 #ifndef BASE_STRINGS_UTF_STRING_CONVERSIONS_H_
6 #define BASE_STRINGS_UTF_STRING_CONVERSIONS_H_ 6 #define BASE_STRINGS_UTF_STRING_CONVERSIONS_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/base_export.h" 10 #include "base/base_export.h"
(...skipping 21 matching lines...) Expand all
32 BASE_EXPORT bool UTF16ToWide(const char16* src, size_t src_len, 32 BASE_EXPORT bool UTF16ToWide(const char16* src, size_t src_len,
33 std::wstring* output); 33 std::wstring* output);
34 BASE_EXPORT std::wstring UTF16ToWide(const string16& utf16); 34 BASE_EXPORT std::wstring UTF16ToWide(const string16& utf16);
35 35
36 BASE_EXPORT bool UTF8ToUTF16(const char* src, size_t src_len, string16* output); 36 BASE_EXPORT bool UTF8ToUTF16(const char* src, size_t src_len, string16* output);
37 BASE_EXPORT string16 UTF8ToUTF16(const StringPiece& utf8); 37 BASE_EXPORT string16 UTF8ToUTF16(const StringPiece& utf8);
38 BASE_EXPORT bool UTF16ToUTF8(const char16* src, size_t src_len, 38 BASE_EXPORT bool UTF16ToUTF8(const char16* src, size_t src_len,
39 std::string* output); 39 std::string* output);
40 BASE_EXPORT std::string UTF16ToUTF8(const string16& utf16); 40 BASE_EXPORT std::string UTF16ToUTF8(const string16& utf16);
41 41
42 // We are trying to get rid of wstring as much as possible, but it's too big
43 // a mess to do it all at once. These conversions should be used when we
44 // really should just be passing a string16 around, but we haven't finished
45 // porting whatever module uses wstring and the conversion is being used as a
46 // stopcock. This makes it easy to grep for the ones that should be removed.
47 #if defined(OS_WIN)
48 # define WideToUTF16Hack
49 # define UTF16ToWideHack
50 #else
51 # define WideToUTF16Hack WideToUTF16
52 # define UTF16ToWideHack UTF16ToWide
53 #endif
54
55 // These convert an ASCII string, typically a hardcoded constant, to a 42 // These convert an ASCII string, typically a hardcoded constant, to a
56 // UTF16/Wide string. 43 // UTF16/Wide string.
57 BASE_EXPORT std::wstring ASCIIToWide(const StringPiece& ascii); 44 BASE_EXPORT std::wstring ASCIIToWide(const StringPiece& ascii);
58 BASE_EXPORT string16 ASCIIToUTF16(const StringPiece& ascii); 45 BASE_EXPORT string16 ASCIIToUTF16(const StringPiece& ascii);
59 46
60 } // namespace base 47 } // namespace base
61 48
62 // TODO(brettw) remove these when callers are fixed up. 49 // We are trying to get rid of wstring as much as possible, but it's too big a
63 using base::WideToUTF8; 50 // mess to do it all at once. These synonyms should be used when we really
64 using base::UTF8ToWide; 51 // should just be passing a string16 around, but we haven't finished porting
65 using base::WideToUTF16; 52 // whatever module uses wstring and the conversion is being used as a stopgap.
66 using base::UTF16ToWide; 53 // This makes it easy to grep for the ones that should be removed.
67 using base::UTF8ToUTF16; 54 #define WideToUTF16Hack WideToUTF16
68 using base::UTF16ToUTF8; 55 #define UTF16ToWideHack UTF16ToWide
69 using base::ASCIIToWide;
70 using base::ASCIIToUTF16;
71 56
72 #endif // BASE_STRINGS_UTF_STRING_CONVERSIONS_H_ 57 #endif // BASE_STRINGS_UTF_STRING_CONVERSIONS_H_
OLDNEW
« no previous file with comments | « base/strings/string_util.cc ('k') | base/test/test_file_util_posix.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698