chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc - Issue 102993018: Remove UTF string conversion functions from the global namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc

Issue 102993018: Remove UTF string conversion functions from the global namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: aaaaaaaaaa Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/password_autofill_agent_browsertest.cc ('k') | chrome/renderer/spellchecker/spellcheck_provider_hunspell_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc

diff --git a/chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc b/chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc

index e2b121a2e9922e77e3204dc37ebb15e8fc09b9b4..b8627de34d3a756c2a9ac2707a3e7bb340d9aea6 100644

--- a/chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc

+++ b/chrome/renderer/safe_browsing/phishing_term_feature_extractor_unittest.cc

@@ -188,7 +188,8 @@ TEST_F(PhishingTermFeatureExtractorTest, ExtractFeatures) {

// Chinese translation of the phrase "hello goodbye". This tests that

// we can correctly separate terms in languages that don't use spaces.

- page_text = UTF8ToUTF16("\xe4\xbd\xa0\xe5\xa5\xbd\xe5\x86\x8d\xe8\xa7\x81");

+ page_text =

+ base::UTF8ToUTF16("\xe4\xbd\xa0\xe5\xa5\xbd\xe5\x86\x8d\xe8\xa7\x81");

expected_features.Clear();

expected_features.AddBooleanFeature(

features::kPageTerm + std::string("\xe4\xbd\xa0\xe5\xa5\xbd"));