Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 1027753003: Add divide to Sk2x, use native vdiv and vsqrt on ARM 64. (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
msarett, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add divide to Sk2x, use native vdiv and vsqrt on ARM 64. Tests pass on N7 + N9. BUG=skia: CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Mac10.7-Clang-Arm7-Debug-iOS-Trybot,Build-Ubuntu-GCC-Arm64-Release-Android-Trybot Committed: https://skia.googlesource.com/skia/+/01a78130dc357e5ee746a37650dba622e0c07f8e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -10 lines) Patch
M src/core/Sk2x.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/opts/Sk2x_neon.h View 5 chunks +17 lines, -7 lines 0 comments Download
M src/opts/Sk2x_none.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/opts/Sk2x_sse.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/opts/Sk4x_neon.h View 2 chunks +11 lines, -3 lines 0 comments Download
M tests/Sk2xTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein_C
5 years, 9 months ago (2015-03-20 17:25:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1027753003/1
5 years, 9 months ago (2015-03-20 17:26:20 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-20 17:26:21 UTC) #5
reed1
lgtm
5 years, 9 months ago (2015-03-20 18:26:56 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 18:28:59 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/01a78130dc357e5ee746a37650dba622e0c07f8e

Powered by Google App Engine
This is Rietveld 408576698