Removed implicit cast from size_t to int, prevent an unlikely but theoretically possible integer ov…

Removed implicit cast from size_t to int, prevent an unlikely but theoretically possible integer overflow.

BUG=none

Committed: https://crrev.com/0d104215876d5e7737a76b505ec7a4b00a3e28b5
Cr-Commit-Position: refs/heads/master@{#321908}

[fahl, 2015-03-23 21:45:05]

fahl@chromium.org changed reviewers:
+ felt@chromium.org, meacer@chromium.org

[meacer, 2015-03-23 21:54:30]

https://codereview.chromium.org/1025523004/diff/1/chrome/browser/ssl/ssl_erro...
File chrome/browser/ssl/ssl_error_info.h (right):

https://codereview.chromium.org/1025523004/diff/1/chrome/browser/ssl/ssl_erro...
chrome/browser/ssl/ssl_error_info.h:56: static size_t GetErrorsForCertStatus(int
cert_id,
I was going to suggest renaming this to GetNumErrorsForCertStatus, but it looks
like the return value isn't used at all:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

Perhaps you could just return a bool and DCHECK() it, or just use void?

[fahl, 2015-03-23 22:05:05]

On 2015/03/23 21:54:30, Mustafa Emre Acer wrote:
>
https://codereview.chromium.org/1025523004/diff/1/chrome/browser/ssl/ssl_erro...
> File chrome/browser/ssl/ssl_error_info.h (right):
> 
>
https://codereview.chromium.org/1025523004/diff/1/chrome/browser/ssl/ssl_erro...
> chrome/browser/ssl/ssl_error_info.h:56: static size_t
GetErrorsForCertStatus(int
> cert_id,
> I was going to suggest renaming this to GetNumErrorsForCertStatus, but it
looks
> like the return value isn't used at all:
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
> 
> Perhaps you could just return a bool and DCHECK() it, or just use void?

The return value isn't used anywhere. Making it void probably would be the
safest option. Adrienne what to you think?

[felt, 2015-03-23 22:19:54]

On 2015/03/23 22:05:05, fahl wrote:
> On 2015/03/23 21:54:30, Mustafa Emre Acer wrote:
> >
>
https://codereview.chromium.org/1025523004/diff/1/chrome/browser/ssl/ssl_erro...
> > File chrome/browser/ssl/ssl_error_info.h (right):
> > 
> >
>
https://codereview.chromium.org/1025523004/diff/1/chrome/browser/ssl/ssl_erro...
> > chrome/browser/ssl/ssl_error_info.h:56: static size_t
> GetErrorsForCertStatus(int
> > cert_id,
> > I was going to suggest renaming this to GetNumErrorsForCertStatus, but it
> looks
> > like the return value isn't used at all:
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
> > 
> > Perhaps you could just return a bool and DCHECK() it, or just use void?
> 
> The return value isn't used anywhere. Making it void probably would be the
> safest option. Adrienne what to you think?

If the return value isn't used anywhere, I'm fine making it void.

[felt, 2015-03-23 22:49:45]

lgtm, assuming the trybot gods are pleased with this offering

[fahl, 2015-03-23 23:29:36]

The CQ bit was checked by fahl@chromium.org

[commit-bot: I haz the power, 2015-03-23 23:29:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1025523004/20001

[commit-bot: I haz the power, 2015-03-24 00:25:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-24 00:26:12]

Patchset 2 (id:??) landed as
https://crrev.com/0d104215876d5e7737a76b505ec7a4b00a3e28b5
Cr-Commit-Position: refs/heads/master@{#321908}