Removed implicit cast from size_t to int, prevent an unlikely but theoretically possible integer ov…

chrome/browser/ssl/ssl_error_info.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SSL_SSL_ERROR_INFO_H_
 #define CHROME_BROWSER_SSL_SSL_ERROR_INFO_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 35 matching lines @@
   static ErrorType NetErrorToErrorType(int net_error);
 
   static SSLErrorInfo CreateError(ErrorType error_type,
                                   net::X509Certificate* cert,
                                   const GURL& request_url);
 
   // Populates the specified |errors| vector with the errors contained in
   // |cert_status|.  Returns the number of errors found.
   // Callers only interested in the error count can pass NULL for |errors|.
   // TODO(wtc): Document |cert_id| and |url| arguments.
-  static int GetErrorsForCertStatus(int cert_id,
-                                    net::CertStatus cert_status,
-                                    const GURL& url,
-                                    std::vector<SSLErrorInfo>* errors);
+  static size_t GetErrorsForCertStatus(int cert_id,

[meacer, 2015/03/23 21:54:30]

I was going to suggest renaming this to GetNumErrorsForCertStatus, but it looks
like the return value isn't used at all:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

Perhaps you could just return a bool and DCHECK() it, or just use void?

+                                       net::CertStatus cert_status,
+                                       const GURL& url,
+                                       std::vector<SSLErrorInfo>* errors);
 
   // A description of the error.
   const base::string16& details() const { return details_; }
 
   // A short message describing the error (1 line).
   const base::string16& short_description() const { return short_description_; }
 
  private:
   SSLErrorInfo(const base::string16& details,
                const base::string16& short_description);
 
   base::string16 details_;
   base::string16 short_description_;
 };
 
 #endif  // CHROME_BROWSER_SSL_SSL_ERROR_INFO_H_