Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4743)

Unified Diff: chrome/browser/ssl/ssl_error_info.h

Issue 1025523004: Removed implicit cast from size_t to int, prevent an unlikely but theoretically possible integer ov… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Made it a void function since the return value is never used. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ssl/ssl_error_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/ssl_error_info.h
diff --git a/chrome/browser/ssl/ssl_error_info.h b/chrome/browser/ssl/ssl_error_info.h
index 2713374cf232bdfe3b1a4c74e118344523514e54..0ffd5539826ccd56f3d17cde61933dd43636c0f9 100644
--- a/chrome/browser/ssl/ssl_error_info.h
+++ b/chrome/browser/ssl/ssl_error_info.h
@@ -53,10 +53,10 @@ class SSLErrorInfo {
// |cert_status|. Returns the number of errors found.
// Callers only interested in the error count can pass NULL for |errors|.
// TODO(wtc): Document |cert_id| and |url| arguments.
- static int GetErrorsForCertStatus(int cert_id,
- net::CertStatus cert_status,
- const GURL& url,
- std::vector<SSLErrorInfo>* errors);
+ static void GetErrorsForCertStatus(int cert_id,
+ net::CertStatus cert_status,
+ const GURL& url,
+ std::vector<SSLErrorInfo>* errors);
// A description of the error.
const base::string16& details() const { return details_; }
« no previous file with comments | « no previous file | chrome/browser/ssl/ssl_error_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698