Removed implicit cast from size_t to int, prevent an unlikely but theoretically possible integer ov…

chrome/browser/ssl/ssl_error_info.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ssl/ssl_error_info.h"
 
 #include "base/i18n/time_formatting.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/grit/chromium_strings.h"
@@ skipping 193 matching lines @@
       return CERT_WEAK_KEY_DH;
     case net::ERR_SSL_PINNED_KEY_NOT_IN_CERT_CHAIN:
       return CERT_PINNED_KEY_MISSING;
     default:
       NOTREACHED();
       return UNKNOWN;
     }
 }
 
 // static
-int SSLErrorInfo::GetErrorsForCertStatus(int cert_id,
-                                         net::CertStatus cert_status,
-                                         const GURL& url,
-                                         std::vector<SSLErrorInfo>* errors) {
+void SSLErrorInfo::GetErrorsForCertStatus(int cert_id,
+                                          net::CertStatus cert_status,
+                                          const GURL& url,
+                                          std::vector<SSLErrorInfo>* errors) {
   const net::CertStatus kErrorFlags[] = {
       net::CERT_STATUS_COMMON_NAME_INVALID,
       net::CERT_STATUS_DATE_INVALID,
       net::CERT_STATUS_AUTHORITY_INVALID,
       net::CERT_STATUS_NO_REVOCATION_MECHANISM,
       net::CERT_STATUS_UNABLE_TO_CHECK_REVOCATION,
       net::CERT_STATUS_REVOKED,
       net::CERT_STATUS_INVALID,
       net::CERT_STATUS_WEAK_SIGNATURE_ALGORITHM,
       net::CERT_STATUS_WEAK_KEY,
@@ skipping 10 matching lines @@
       CERT_REVOKED,
       CERT_INVALID,
       CERT_WEAK_SIGNATURE_ALGORITHM,
       CERT_WEAK_KEY,
       CERT_NAME_CONSTRAINT_VIOLATION,
       CERT_VALIDITY_TOO_LONG,
   };
   DCHECK(arraysize(kErrorFlags) == arraysize(kErrorTypes));
 
   scoped_refptr<net::X509Certificate> cert = NULL;
-  int count = 0;
   for (size_t i = 0; i < arraysize(kErrorFlags); ++i) {
     if (cert_status & kErrorFlags[i]) {
-      count++;
       if (!cert.get()) {
         bool r = content::CertStore::GetInstance()->RetrieveCert(
             cert_id, &cert);
         DCHECK(r);
       }
       if (errors) {
         errors->push_back(
             SSLErrorInfo::CreateError(kErrorTypes[i], cert.get(), url));
       }
     }
   }
-  return count;
 }