Add cookies' first-partyness to chrome://settings/cookies

Add cookies' first-partyness to chrome://settings/cookies

This patch supports the new 'First-Party-Only' cookie attribute by
changing the "Send for:" value in the cookies WebUI table to one of the
following:

* "Any kind of connection"
* "Secure connections only"
* "First-party connections only"
* "Secure first-party connections only"

BUG=468709
Committed: https://crrev.com/89f2424c956777c91b58c2e953b62523b7f9c49e
Cr-Commit-Position: refs/heads/master@{#321997}

[Mike West, 2015-03-19 11:26:28]

mkwst@chromium.org changed reviewers:
+ bauerb@chromium.org, pkasting@chromium.org

[Mike West, 2015-03-19 11:26:29]

Hello, lovely reviewers! Would you mind taking a look at the following files?

thakis@: c/b/ui/cocoa/content_settings/
pkasting@: c/b/ui/views/
estade@: c/b/ui/webui/

They all do more or less the same thing: map combinations of cookies' `IsSecure`
and `IsFirstPartyOnly` properties to one of the four possible strings that can
be displayed in chrome://settings/cookies detail view.

Thanks!

-mike

[Peter Kasting, 2015-03-19 20:59:33]

Nesting ?:s is ugly, but the alternatives aren't really much more readable.  :/

LGTM

[Mike West, 2015-03-20 08:36:21]

mkwst@chromium.org changed reviewers:
+ pam@chromium.org, thakis@chromium.org
- bauerb@chromium.org

[Mike West, 2015-03-20 08:36:21]

Swapping in pam@ for chrome/browser/ui/webui because time-zones (and actually
adding thakis@ this time...).

[Pam (message me for reviews), 2015-03-20 10:30:39]

https://codereview.chromium.org/1024503002/diff/1/chrome/browser/ui/views/coo...
File chrome/browser/ui/views/cookie_info_view.cc (right):

https://codereview.chromium.org/1024503002/diff/1/chrome/browser/ui/views/coo...
chrome/browser/ui/views/cookie_info_view.cc:72: :
IDS_COOKIES_COOKIE_SENDFOR_ANY));
Oh dear. There aren't any really great solutions here, but this is really hard
to read. I'd suggest one if-then split, i.e.

if (cookie.IsSecure()) {
  cookie_text = cookie.IsFirstPartyOnly() ?
      IDS_COOKIES_COOKIE_SENDFOR_SECURE_FIRSTPARTY :
      COOKIE_SENDFOR_SECURE;
} else {
 cookie_text = cookie.IsFirstPartyOnly() ?
      IDS_COOKIES_COOKIE_SENDFOR_FIRSTPARTY :
      COOKIE_SENDFOR_ANY;
}

https://codereview.chromium.org/1024503002/diff/1/chrome/browser/ui/webui/coo...
File chrome/browser/ui/webui/cookies_tree_model_util.cc (right):

https://codereview.chromium.org/1024503002/diff/1/chrome/browser/ui/webui/coo...
chrome/browser/ui/webui/cookies_tree_model_util.cc:137: :
IDS_COOKIES_COOKIE_SENDFOR_ANY));
same here, more so

[Nico, 2015-03-20 14:04:11]

https://codereview.chromium.org/1024503002/diff/1/chrome/browser/ui/cocoa/con...
File chrome/browser/ui/cocoa/content_settings/cookie_details.mm (right):

https://codereview.chromium.org/1024503002/diff/1/chrome/browser/ui/cocoa/con...
chrome/browser/ui/cocoa/content_settings/cookie_details.mm:150: if
(cookie->IsSecure()) {
Could the cookie -> resource id mapping function be in some shared place? That's
identical for all ports, right?

[Mike West, 2015-03-20 14:10:10]

On 2015/03/20 at 14:04:11, thakis wrote:
>
https://codereview.chromium.org/1024503002/diff/1/chrome/browser/ui/cocoa/con...
> chrome/browser/ui/cocoa/content_settings/cookie_details.mm:150: if
(cookie->IsSecure()) {
> Could the cookie -> resource id mapping function be in some shared place?
That's identical for all ports, right?

It could! Do you have opinions about where that might be?

[Mike West, 2015-03-20 14:29:19]

On 2015/03/20 at 14:10:10, Mike West wrote:
> On 2015/03/20 at 14:04:11, thakis wrote:
> >
https://codereview.chromium.org/1024503002/diff/1/chrome/browser/ui/cocoa/con...
> > chrome/browser/ui/cocoa/content_settings/cookie_details.mm:150: if
(cookie->IsSecure()) {
> > Could the cookie -> resource id mapping function be in some shared place?
That's identical for all ports, right?
> 
> It could! Do you have opinions about where that might be?

How about a static `CookiesTreeModel::GetSendForMessageID`? It's already
included in all these files, and seems like a reasonable way of cleaning things
up. I actually like this more than the original code now...

[Mike West, 2015-03-23 11:58:25]

On 2015/03/20 at 14:29:19, Mike West wrote:
> On 2015/03/20 at 14:10:10, Mike West wrote:
> > On 2015/03/20 at 14:04:11, thakis wrote:
> > >
https://codereview.chromium.org/1024503002/diff/1/chrome/browser/ui/cocoa/con...
> > > chrome/browser/ui/cocoa/content_settings/cookie_details.mm:150: if
(cookie->IsSecure()) {
> > > Could the cookie -> resource id mapping function be in some shared place?
That's identical for all ports, right?
> > 
> > It could! Do you have opinions about where that might be?
> 
> How about a static `CookiesTreeModel::GetSendForMessageID`? It's already
included in all these files, and seems like a reasonable way of cleaning things
up. I actually like this more than the original code now...

Ping. :)

[Pam (message me for reviews), 2015-03-23 12:23:45]

On 2015/03/23 11:58:25, Mike West wrote:
> On 2015/03/20 at 14:29:19, Mike West wrote:
> > On 2015/03/20 at 14:10:10, Mike West wrote:
> > > On 2015/03/20 at 14:04:11, thakis wrote:
> > > >
>
https://codereview.chromium.org/1024503002/diff/1/chrome/browser/ui/cocoa/con...
> > > > chrome/browser/ui/cocoa/content_settings/cookie_details.mm:150: if
> (cookie->IsSecure()) {
> > > > Could the cookie -> resource id mapping function be in some shared
place?
> That's identical for all ports, right?
> > > 
> > > It could! Do you have opinions about where that might be?
> > 
> > How about a static `CookiesTreeModel::GetSendForMessageID`? It's already
> included in all these files, and seems like a reasonable way of cleaning
things
> up. I actually like this more than the original code now...
> 
> Ping. :)

LGTM

[Mike West, 2015-03-24 13:08:21]

mkwst@chromium.org changed reviewers:
+ bauerb@chromium.org

[Mike West, 2015-03-24 13:08:22]

Bernhard, perhaps you could take a quick look at the cocoa change?

[Bernhard Bauer, 2015-03-24 13:48:55]

lgtm

[Mike West, 2015-03-24 13:55:11]

The CQ bit was checked by mkwst@chromium.org

[Mike West, 2015-03-24 13:55:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/1024503002/#ps20001
(title: "How about this?")

[commit-bot: I haz the power, 2015-03-24 13:55:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1024503002/20001

[commit-bot: I haz the power, 2015-03-24 15:01:56]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-24 15:02:23]

Patchset 2 (id:??) landed as
https://crrev.com/89f2424c956777c91b58c2e953b62523b7f9c49e
Cr-Commit-Position: refs/heads/master@{#321997}