Add cookies' first-partyness to chrome://settings/cookies

chrome/browser/ui/cocoa/content_settings/cookie_details.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/content_settings/cookie_details.h"
 
 #import "base/i18n/time_formatting.h"
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/browser/browsing_data/cookies_tree_model.h"
 #include "chrome/grit/generated_resources.h"
@@ skipping 129 matching lines @@
       expires_.reset([base::SysUTF16ToNSString(
           base::TimeFormatFriendlyDateAndTime(cookie->ExpiryDate())) retain]);
     } else {
       expires_.reset([l10n_util::GetNSStringWithFixup(
           IDS_COOKIES_COOKIE_EXPIRES_SESSION) retain]);
     }
 
     created_.reset([base::SysUTF16ToNSString(
         base::TimeFormatFriendlyDateAndTime(cookie->CreationDate())) retain]);
 
     if (cookie->IsSecure()) {

[Nico, 2015/03/20 14:04:11]

Could the cookie -> resource id mapping function be in some shared place? That's
identical for all ports, right?

-      sendFor_.reset([l10n_util::GetNSStringWithFixup(
-          IDS_COOKIES_COOKIE_SENDFOR_SECURE) retain]);
+      if (cookie->IsFirstPartyOnly()) {
+        sendFor_.reset([l10n_util::GetNSStringWithFixup(
+            IDS_COOKIES_COOKIE_SENDFOR_SECURE_FIRSTPARTY) retain]);
+      } else {
+        sendFor_.reset([l10n_util::GetNSStringWithFixup(
+            IDS_COOKIES_COOKIE_SENDFOR_SECURE) retain]);
+      }
     } else {
-      sendFor_.reset([l10n_util::GetNSStringWithFixup(
-          IDS_COOKIES_COOKIE_SENDFOR_ANY) retain]);
+      if (cookie->IsFirstPartyOnly()) {
+        sendFor_.reset([l10n_util::GetNSStringWithFixup(
+            IDS_COOKIES_COOKIE_SENDFOR_FIRSTPARTY) retain]);
+      } else {
+        sendFor_.reset([l10n_util::GetNSStringWithFixup(
+            IDS_COOKIES_COOKIE_SENDFOR_ANY) retain]);
+      }
     }
   }
   return self;
 }
 
 - (id)initWithDatabase:(const BrowsingDataDatabaseHelper::DatabaseInfo*)
     databaseInfo {
   if ((self = [super init])) {
     type_ = kCocoaCookieDetailsTypeTreeDatabase;
     canEditExpiration_ = NO;
@@ skipping 157 matching lines @@
     details_.reset([details retain]);
   }
   return self;
 }
 
 - (CocoaCookieDetails*)details {
   return details_.get();
 }
 
 @end