chrome/browser/ui/views/cookie_info_view.cc - Issue 1024503002: Add cookies' first-partyness to chrome://settings/cookies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/cookie_info_view.cc

Issue 1024503002: Add cookies' first-partyness to chrome://settings/cookies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: How about this? Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/content_settings/cookie_details.mm ('k') | chrome/browser/ui/webui/cookies_tree_model_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/cookie_info_view.cc

diff --git a/chrome/browser/ui/views/cookie_info_view.cc b/chrome/browser/ui/views/cookie_info_view.cc

index a22f30257566f90cf3ac79fba4442523a3f4469e..523500e8504a86589b3c88cfdbdf54f2ccf936f1 100644

--- a/chrome/browser/ui/views/cookie_info_view.cc

+++ b/chrome/browser/ui/views/cookie_info_view.cc

@@ -63,9 +63,8 @@ void CookieInfoView::SetCookie(const std::string& domain,

l10n_util::GetStringUTF16(IDS_COOKIES_COOKIE_EXPIRES_SESSION);

expires_value_field_->SetText(expire_text);

- send_for_value_field_->SetText(cookie.IsSecure() ?

- l10n_util::GetStringUTF16(IDS_COOKIES_COOKIE_SENDFOR_SECURE) :

- l10n_util::GetStringUTF16(IDS_COOKIES_COOKIE_SENDFOR_ANY));

+ send_for_value_field_->SetText(

+ l10n_util::GetStringUTF16(CookiesTreeModel::GetSendForMessageID(cookie)));

EnableCookieDisplay(true);

Layout();

}

« no previous file with comments | « chrome/browser/ui/cocoa/content_settings/cookie_details.mm ('k') | chrome/browser/ui/webui/cookies_tree_model_util.cc » ('j') | no next file with comments »