Add cookies' first-partyness to chrome://settings/cookies

chrome/browser/ui/views/cookie_info_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/cookie_info_view.h"
 
 #include <algorithm>
 
 #include "base/i18n/time_formatting.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 45 matching lines @@
   domain_value_field_->SetText(base::UTF8ToUTF16(domain));
   path_value_field_->SetText(base::UTF8ToUTF16(cookie.Path()));
   created_value_field_->SetText(
       base::TimeFormatFriendlyDateAndTime(cookie.CreationDate()));
 
   base::string16 expire_text = cookie.IsPersistent() ?
       base::TimeFormatFriendlyDateAndTime(cookie.ExpiryDate()) :
       l10n_util::GetStringUTF16(IDS_COOKIES_COOKIE_EXPIRES_SESSION);
 
   expires_value_field_->SetText(expire_text);
-  send_for_value_field_->SetText(cookie.IsSecure() ?
-      l10n_util::GetStringUTF16(IDS_COOKIES_COOKIE_SENDFOR_SECURE) :
-      l10n_util::GetStringUTF16(IDS_COOKIES_COOKIE_SENDFOR_ANY));
+  send_for_value_field_->SetText(l10n_util::GetStringUTF16(
+      cookie.IsSecure()
+          ? cookie.IsFirstPartyOnly()
+                ? IDS_COOKIES_COOKIE_SENDFOR_SECURE_FIRSTPARTY
+                : IDS_COOKIES_COOKIE_SENDFOR_SECURE
+          : cookie.IsFirstPartyOnly() ? IDS_COOKIES_COOKIE_SENDFOR_FIRSTPARTY
+                                      : IDS_COOKIES_COOKIE_SENDFOR_ANY));

[Pam (message me for reviews), 2015/03/20 10:30:38]

Oh dear. There aren't any really great solutions here, but this is really hard
to read. I'd suggest one if-then split, i.e.

if (cookie.IsSecure()) {
  cookie_text = cookie.IsFirstPartyOnly() ?
      IDS_COOKIES_COOKIE_SENDFOR_SECURE_FIRSTPARTY :
      COOKIE_SENDFOR_SECURE;
} else {
 cookie_text = cookie.IsFirstPartyOnly() ?
      IDS_COOKIES_COOKIE_SENDFOR_FIRSTPARTY :
      COOKIE_SENDFOR_ANY;
}

   EnableCookieDisplay(true);
   Layout();
 }
 
 void CookieInfoView::SetCookieString(const GURL& url,
                                      const std::string& cookie_line) {
   net::ParsedCookie pc(cookie_line);
   net::CanonicalCookie cookie(url, pc);
   SetCookie(pc.HasDomain() ? pc.Domain() : url.host(), cookie);
 }
@@ skipping 98 matching lines @@
   AddLabelRow(three_column_layout_id, layout, domain_label_,
               domain_value_field_);
   AddLabelRow(three_column_layout_id, layout, path_label_, path_value_field_);
   AddLabelRow(three_column_layout_id, layout, send_for_label_,
               send_for_value_field_);
   AddLabelRow(three_column_layout_id, layout, created_label_,
               created_value_field_);
   AddLabelRow(three_column_layout_id, layout, expires_label_,
               expires_value_field_);
 }