Move some flag-like props from GlobalContext and TargetLowering to ClFlags.

Move some flag-like props from GlobalContext and TargetLowering to ClFlags.


Simplifies the GlobalContext constructor so that a future
change may just set up the flags and the GlobalContext
before calling into what is currently "main".
Namely this change:
https://codereview.chromium.org/997773002/

This also moves all uses of LLVM's CommandLine.h to
a single file, so that in the future we may be able
to simplify the flags parsing (especially for the
minimal build).

BUG= https://code.google.com/p/nativeclient/issues/detail?id=4091
BUG= https://code.google.com/p/nativeclient/issues/detail?id=4084
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=1f47ad02c2db6427f53438f764c1299fe55dfcbd

[jvoung (off chromium), 2015-03-20 20:40:26]

jvoung@chromium.org changed reviewers:
+ kschimpf@google.com, mtrofin@chromium.org, stichnot@chromium.org

[jvoung (off chromium), 2015-03-20 20:47:10]

https://codereview.chromium.org/1024203002/diff/1/src/IceELFObjectWriter.cpp
File src/IceELFObjectWriter.cpp (right):

https://codereview.chromium.org/1024203002/diff/1/src/IceELFObjectWriter.cpp#...
src/IceELFObjectWriter.cpp:429: template <bool IsELF64>
I removed all the local "bool IsELF64 = isELF64(Ctx.getTargetArch());" and
propagation of that, and replaced it with a field ELF64.

Didn't name the field "IsELF64" because in conflicts with this template
parameter...

[Jim Stichnoth, 2015-03-20 21:19:25]

lgtm

https://codereview.chromium.org/1024203002/diff/20001/src/IceELFObjectWriter.cpp
File src/IceELFObjectWriter.cpp (right):

https://codereview.chromium.org/1024203002/diff/20001/src/IceELFObjectWriter....
src/IceELFObjectWriter.cpp:461: // e_flags
unfortunate clang_formatting... maybe copy Ctx.getFlags().getTargetArch() into a
local var to shorten the line?

https://codereview.chromium.org/1024203002/diff/20001/src/IceGlobalContext.cpp
File src/IceGlobalContext.cpp (right):

https://codereview.chromium.org/1024203002/diff/20001/src/IceGlobalContext.cp...
src/IceGlobalContext.cpp:167: StrEmit(OsEmit), Flags(Flags),
RNG(Flags.getRandomSeed(), ""),
The "" is a little hard to read.  How about omitting it and making it the
default parameter value in the ctor?

[jvoung (off chromium), 2015-03-20 21:46:28]

https://codereview.chromium.org/1024203002/diff/20001/src/IceELFObjectWriter.cpp
File src/IceELFObjectWriter.cpp (right):

https://codereview.chromium.org/1024203002/diff/20001/src/IceELFObjectWriter....
src/IceELFObjectWriter.cpp:461: // e_flags
On 2015/03/20 21:19:25, stichnot wrote:
> unfortunate clang_formatting... maybe copy Ctx.getFlags().getTargetArch() into
a
> local var to shorten the line?

Done.

https://codereview.chromium.org/1024203002/diff/20001/src/IceGlobalContext.cpp
File src/IceGlobalContext.cpp (right):

https://codereview.chromium.org/1024203002/diff/20001/src/IceGlobalContext.cp...
src/IceGlobalContext.cpp:167: StrEmit(OsEmit), Flags(Flags),
RNG(Flags.getRandomSeed(), ""),
On 2015/03/20 21:19:25, stichnot wrote:
> The "" is a little hard to read.  How about omitting it and making it the
> default parameter value in the ctor?

Done.

[jvoung (off chromium), 2015-03-20 22:01:33]

Committed patchset #3 (id:30001) manually as
1f47ad02c2db6427f53438f764c1299fe55dfcbd (presubmit successful).