Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: src/IceELFObjectWriter.h

Issue 1024203002: Move some flag-like props from GlobalContext and TargetLowering to ClFlags. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: review / clean up formatting Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceClFlags.h ('k') | src/IceELFObjectWriter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceELFObjectWriter.h
diff --git a/src/IceELFObjectWriter.h b/src/IceELFObjectWriter.h
index d27ee9c065faaa26d617ce9356bc651877b91433..11038455616eab6a33b44ea83a8c67c58fd53bd1 100644
--- a/src/IceELFObjectWriter.h
+++ b/src/IceELFObjectWriter.h
@@ -93,6 +93,7 @@ private:
GlobalContext &Ctx;
ELFStreamer &Str;
bool SectionNumbersAssigned;
+ bool ELF64;
// All created sections, separated into different pools.
typedef std::vector<ELFSection *> SectionList;
@@ -121,7 +122,7 @@ private:
// Create a relocation section, given the related section
// (e.g., .text, .data., .rodata).
ELFRelocationSection *
- createRelocationSection(bool IsELF64, const ELFSection *RelatedSection);
+ createRelocationSection(const ELFSection *RelatedSection);
// Align the file position before writing out a section's data,
// and return the position of the file.
@@ -150,13 +151,13 @@ private:
// SectionType, given the global variables Vars belonging to that SectionType.
void writeDataOfType(SectionType SectionType,
const VariableDeclarationList &Vars,
- FixupKind RelocationKind, bool IsELF64);
+ FixupKind RelocationKind);
// Write the final relocation sections given the final symbol table.
// May also be able to seek around the file and resolve function calls
// that are for functions within the same section.
- void writeAllRelocationSections(bool IsELF64);
- void writeRelocationSections(bool IsELF64, RelSectionList &RelSections);
+ void writeAllRelocationSections();
+ void writeRelocationSections(RelSectionList &RelSections);
// Write the ELF file header with the given information about sections.
template <bool IsELF64>
« no previous file with comments | « src/IceClFlags.h ('k') | src/IceELFObjectWriter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698