Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1024103002: [Android WebView] Provide user-initiated provisional load detection (Closed)

Created:
5 years, 9 months ago by mnaganov (inactive)
Modified:
5 years, 9 months ago
Reviewers:
Ted C, no sievers, Torne
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, android-webview-reviews_chromium.org, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android WebView] Provide user-initiated provisional load detection Do not synthesize page loading events on DOM modification, if the provisional load has been started from the API side. It appears that a lot of apps tend to use the following scenario: webView.loadUrl(...); webView.loadUrl('javascript:...'); Which was triggering page loading events to be emitted. This scenario is dubious, as no one guarantees that loading will actually finish prior to executing javascript. But for compatibility reasons we must take it into account and not emit page loading events for "about:blank", as it seems that some apps do unexpected things when they receive it. BUG=458569, 469099 Committed: https://crrev.com/7a3234c9a19a38726a4a984ff12e2b406423c1d3 Cr-Commit-Position: refs/heads/master@{#321857}

Patch Set 1 #

Patch Set 2 : Comments and build fix #

Messages

Total messages: 17 (5 generated)
mnaganov (inactive)
5 years, 9 months ago (2015-03-20 17:01:50 UTC) #2
Torne
Not 100% sure that "user-initiated" is the right way to describe this; it's "everything not ...
5 years, 9 months ago (2015-03-23 11:34:26 UTC) #3
mnaganov (inactive)
On 2015/03/23 11:34:26, Torne wrote: > Not 100% sure that "user-initiated" is the right way ...
5 years, 9 months ago (2015-03-23 11:45:09 UTC) #4
Torne
lgtm
5 years, 9 months ago (2015-03-23 12:17:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024103002/20001
5 years, 9 months ago (2015-03-23 12:44:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/51281)
5 years, 9 months ago (2015-03-23 12:50:07 UTC) #9
mnaganov (inactive)
Argh, need OWNERs approvals for changes in NavigationEntry. tedchoc@: can you please take a look ...
5 years, 9 months ago (2015-03-23 13:02:26 UTC) #11
Ted C
On 2015/03/23 13:02:26, mnaganov (cr) wrote: > Argh, need OWNERs approvals for changes in NavigationEntry. ...
5 years, 9 months ago (2015-03-23 17:39:35 UTC) #12
no sievers
content lgtm
5 years, 9 months ago (2015-03-23 18:34:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024103002/20001
5 years, 9 months ago (2015-03-23 21:24:37 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-23 21:29:08 UTC) #16
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 21:30:15 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7a3234c9a19a38726a4a984ff12e2b406423c1d3
Cr-Commit-Position: refs/heads/master@{#321857}

Powered by Google App Engine
This is Rietveld 408576698