content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java - Issue 1024103002: [Android WebView] Provide user-initiated provisional load detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java

Issue 1024103002: [Android WebView] Provide user-initiated provisional load detection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments and build fix Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigation_controller_android.cc ('k') | content/public/android/java/src/org/chromium/content_public/browser/NavigationEntry.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java b/content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java

index adb20bf90ba1cf5837eab9b4d1c3d7b844da9f2b..aba184a92731cdd01ebafeabd6579c7661d05fbc 100644

--- a/content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java

+++ b/content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java

@@ -248,8 +248,8 @@ import org.chromium.content_public.browser.NavigationHistory;

@CalledByNative

private static NavigationEntry createNavigationEntry(int index, String url,

- String virtualUrl, String originalUrl, String title, Bitmap favicon) {

- return new NavigationEntry(index, url, virtualUrl, originalUrl, title, favicon);

+ String virtualUrl, String originalUrl, String title, Bitmap favicon, int transition) {

+ return new NavigationEntry(index, url, virtualUrl, originalUrl, title, favicon, transition);

}

private native boolean nativeCanGoBack(long nativeNavigationControllerAndroid);