android_webview/java/src/org/chromium/android_webview/AwContents.java - Issue 1024103002: [Android WebView] Provide user-initiated provisional load detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 1024103002: [Android WebView] Provide user-initiated provisional load detection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments and build fix Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: android_webview/java/src/org/chromium/android_webview/AwContents.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java

index a61311ce800572731cec779038efb12f2a33066e..8df209d3878c9013b1e478dcc9910d78a01552aa 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java

@@ -2294,7 +2294,7 @@ public class AwContents implements SmartClipProvider,

public boolean getDidAttemptLoad() {

if (mDidAttemptLoad) return mDidAttemptLoad;

- mDidAttemptLoad = mWebContentsObserver.hasStartedAnyProvisionalLoad();

+ mDidAttemptLoad = mWebContentsObserver.hasStartedNonApiProvisionalLoadInMainFrame();

return mDidAttemptLoad;

}

« no previous file with comments | « no previous file | android_webview/java/src/org/chromium/android_webview/AwWebContentsObserver.java » ('j') | no next file with comments »