chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java - Issue 1024103002: [Android WebView] Provide user-initiated provisional load detection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java

Issue 1024103002: [Android WebView] Provide user-initiated provisional load detection (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments and build fix Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/ClientOnPageFinishedTest.java ('k') | content/browser/frame_host/navigation_controller_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java

index 8b7c19aa14337f11ef0b943465fd4d33b2c0733e..7c15b6142c2f653457cebe91e6e175bb359bf464 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java

@@ -50,8 +50,8 @@ public class NavigationPopupTest extends ChromeShellTestBase {

// Exists solely to expose protected methods to this test.

private static class TestNavigationEntry extends NavigationEntry {

public TestNavigationEntry(int index, String url, String virtualUrl, String originalUrl,

- String title, Bitmap favicon) {

- super(index, url, virtualUrl, originalUrl, title, favicon);

+ String title, Bitmap favicon, int transition) {

+ super(index, url, virtualUrl, originalUrl, title, favicon, transition);

}

@@ -62,9 +62,9 @@ public class NavigationPopupTest extends ChromeShellTestBase {

public TestNavigationController() {

mHistory = new TestNavigationHistory();

mHistory.addEntry(new TestNavigationEntry(

- 1, "about:blank", null, null, "About Blank", null));

+ 1, "about:blank", null, null, "About Blank", null, 0));

mHistory.addEntry(new TestNavigationEntry(

- 5, UrlUtils.encodeHtmlDataUri("<html>1</html>"), null, null, null, null));

+ 5, UrlUtils.encodeHtmlDataUri("<html>1</html>"), null, null, null, null, 0));

}

@Override