Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1023753006: First step towards splitting a full snapshot into a vm isolate snapshot and a (Closed)

Created:
5 years, 9 months ago by siva
Modified:
5 years, 8 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org
Visibility:
Public.

Description

First step towards splitting a full snapshot into a vm isolate snapshot and a regular isolate snapsot. - change gen_snapshot to split a full snapshot into a vm isolate snapshot and an isolate snapshot - change the build process and scripts to account for splitting the full snapshot R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=44814

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -100 lines) Patch
M runtime/bin/bin.gypi View 1 2 3 4 5 chunks +11 lines, -6 lines 0 comments Download
M runtime/bin/gen_snapshot.cc View 1 2 3 4 9 chunks +49 lines, -19 lines 0 comments Download
M runtime/bin/main.cc View 1 2 3 4 5 chunks +12 lines, -7 lines 0 comments Download
M runtime/bin/run_vm_tests.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/snapshot_empty.cc View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/snapshot_in.cc View 1 2 3 4 1 chunk +15 lines, -4 lines 0 comments Download
M runtime/include/dart_api.h View 1 2 3 4 5 chunks +14 lines, -7 lines 0 comments Download
M runtime/tools/create_snapshot_bin.py View 1 2 3 4 3 chunks +13 lines, -3 lines 0 comments Download
M runtime/tools/create_snapshot_file.py View 1 2 3 4 4 chunks +13 lines, -4 lines 0 comments Download
M runtime/vm/benchmark_test.h View 1 2 3 4 2 chunks +8 lines, -4 lines 0 comments Download
M runtime/vm/benchmark_test.cc View 1 2 3 4 4 chunks +12 lines, -6 lines 0 comments Download
M runtime/vm/dart.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/dart.cc View 1 2 3 4 2 chunks +5 lines, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 2 3 4 4 chunks +23 lines, -9 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/snapshot.h View 1 2 3 4 2 chunks +13 lines, -3 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 1 2 3 4 14 chunks +44 lines, -17 lines 0 comments Download
M runtime/vm/unit_test.h View 1 2 3 4 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
siva
5 years, 9 months ago (2015-03-25 00:04:27 UTC) #2
hausner
LGTM
5 years, 9 months ago (2015-03-25 18:02:11 UTC) #3
siva
5 years, 8 months ago (2015-03-31 18:46:37 UTC) #4
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) manually as r44814 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698