Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Unified Diff: runtime/tools/create_snapshot_bin.py

Issue 1023753006: First step towards splitting a full snapshot into a vm isolate snapshot and a (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/include/dart_api.h ('k') | runtime/tools/create_snapshot_file.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/tools/create_snapshot_bin.py
===================================================================
--- runtime/tools/create_snapshot_bin.py (revision 44745)
+++ runtime/tools/create_snapshot_bin.py (working copy)
@@ -24,9 +24,14 @@
result.add_option("--executable",
action="store", type="string",
help="path to snapshot generator executable")
+ result.add_option("--vm_output_bin",
+ action="store", type="string",
+ help="output file name into which vm isolate snapshot in binary form " +
+ "is generated")
result.add_option("--output_bin",
action="store", type="string",
- help="output file name into which snapshot in binary form is generated")
+ help="output file name into which isolate snapshot in binary form " +
+ "is generated")
result.add_option("--script",
action="store", type="string",
help="Dart script for which snapshot is to be generated")
@@ -54,6 +59,9 @@
if not options.executable:
sys.stderr.write('--executable not specified\n')
return False
+ if not options.vm_output_bin:
+ sys.stderr.write('--vm_output_bin not specified\n')
+ return False
if not options.output_bin:
sys.stderr.write('--output_bin not specified\n')
return False
@@ -83,8 +91,10 @@
if options.package_root:
script_args.append(''.join([ "--package_root=", options.package_root]))
- # First setup the snapshot output filename.
- script_args.append(''.join([ "--snapshot=", options.output_bin ]))
+ # First setup the vm isolate and regular isolate snapshot output filename.
+ script_args.append(''.join([ "--vm_isolate_snapshot=",
+ options.vm_output_bin ]))
+ script_args.append(''.join([ "--isolate_snapshot=", options.output_bin ]))
# Next setup all url mapping options specified.
for url_arg in options.url_mapping:
« no previous file with comments | « runtime/include/dart_api.h ('k') | runtime/tools/create_snapshot_file.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698