Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: runtime/vm/benchmark_test.cc

Issue 1023753006: First step towards splitting a full snapshot into a vm isolate snapshot and a (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/benchmark_test.h ('k') | runtime/vm/dart.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/benchmark_test.cc
===================================================================
--- runtime/vm/benchmark_test.cc (revision 44745)
+++ runtime/vm/benchmark_test.cc (working copy)
@@ -428,7 +428,8 @@
"\n";
// Start an Isolate, load a script and create a full snapshot.
- uint8_t* buffer;
+ uint8_t* vm_isolate_snapshot_buffer;
+ uint8_t* isolate_snapshot_buffer;
// Need to load the script into the dart: core library due to
// the import of dart:_internal.
TestCase::LoadCoreTestScript(kScriptChars, NULL);
@@ -435,9 +436,11 @@
Api::CheckAndFinalizePendingClasses(Isolate::Current());
// Write snapshot with object content.
- FullSnapshotWriter writer(&buffer, &malloc_allocator);
+ FullSnapshotWriter writer(&vm_isolate_snapshot_buffer,
+ &isolate_snapshot_buffer,
+ &malloc_allocator);
writer.WriteFullSnapshot();
- const Snapshot* snapshot = Snapshot::SetupFromBuffer(buffer);
+ const Snapshot* snapshot = Snapshot::SetupFromBuffer(isolate_snapshot_buffer);
ASSERT(snapshot->kind() == Snapshot::kFull);
benchmark->set_score(snapshot->length());
}
@@ -459,7 +462,8 @@
"\n";
// Start an Isolate, load a script and create a full snapshot.
- uint8_t* buffer;
+ uint8_t* vm_isolate_snapshot_buffer;
+ uint8_t* isolate_snapshot_buffer;
// Need to load the script into the dart: core library due to
// the import of dart:_internal.
TestCase::LoadCoreTestScript(kScriptChars, NULL);
@@ -466,9 +470,11 @@
Api::CheckAndFinalizePendingClasses(Isolate::Current());
// Write snapshot with object content.
- FullSnapshotWriter writer(&buffer, &malloc_allocator);
+ FullSnapshotWriter writer(&vm_isolate_snapshot_buffer,
+ &isolate_snapshot_buffer,
+ &malloc_allocator);
writer.WriteFullSnapshot();
- const Snapshot* snapshot = Snapshot::SetupFromBuffer(buffer);
+ const Snapshot* snapshot = Snapshot::SetupFromBuffer(isolate_snapshot_buffer);
ASSERT(snapshot->kind() == Snapshot::kFull);
benchmark->set_score(snapshot->length());
}
« no previous file with comments | « runtime/vm/benchmark_test.h ('k') | runtime/vm/dart.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698