Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 1022943002: Cannot use Handle<T>::cast in Unique<T>::cast since it will try to do a T::cast (and its typecheck)… (Closed)

Created:
5 years, 9 months ago by Toon Verwaest
Modified:
5 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Cannot use Handle<T>::cast in Unique<T>::cast since it will try to do a T::cast (and its typecheck) concurrently, which is unsafe concurrently on moving values BUG= Committed: https://crrev.com/bac0853dfbf1ad2f7f5cf39fd4e5f0ec691155b6 Cr-Commit-Position: refs/heads/master@{#27324}

Patch Set 1 #

Patch Set 2 : Make Unique a friend of Handle and directly access location_ #

Patch Set 3 : Locally allow handle deref #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/bootstrapper.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/lookup.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/lookup.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/unique.h View 1 2 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 19 (10 generated)
Toon Verwaest
PTAL
5 years, 9 months ago (2015-03-19 20:34:28 UTC) #2
Yang
lgtm
5 years, 9 months ago (2015-03-19 20:38:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022943002/1
5 years, 9 months ago (2015-03-19 20:39:14 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/3177)
5 years, 9 months ago (2015-03-19 21:17:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022943002/20001
5 years, 9 months ago (2015-03-19 21:36:06 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/957)
5 years, 9 months ago (2015-03-19 21:50:27 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1022943002/40001
5 years, 9 months ago (2015-03-19 23:17:14 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-19 23:54:12 UTC) #18
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 23:54:24 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bac0853dfbf1ad2f7f5cf39fd4e5f0ec691155b6
Cr-Commit-Position: refs/heads/master@{#27324}

Powered by Google App Engine
This is Rietveld 408576698