Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: src/lookup.cc

Issue 1022943002: Cannot use Handle<T>::cast in Unique<T>::cast since it will try to do a T::cast (and its typecheck)… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Locally allow handle deref Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/lookup.h ('k') | src/unique.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/deoptimizer.h" 8 #include "src/deoptimizer.h"
9 #include "src/lookup.h" 9 #include "src/lookup.h"
10 #include "src/lookup-inl.h" 10 #include "src/lookup-inl.h"
(...skipping 294 matching lines...) Expand 10 before | Expand all | Expand 10 after
305 holder_map_->instance_descriptors()->GetFieldType(descriptor_number()), 305 holder_map_->instance_descriptors()->GetFieldType(descriptor_number()),
306 isolate_); 306 isolate_);
307 } 307 }
308 308
309 309
310 Handle<PropertyCell> LookupIterator::GetPropertyCell() const { 310 Handle<PropertyCell> LookupIterator::GetPropertyCell() const {
311 Handle<JSObject> holder = GetHolder<JSObject>(); 311 Handle<JSObject> holder = GetHolder<JSObject>();
312 Handle<GlobalObject> global = Handle<GlobalObject>::cast(holder); 312 Handle<GlobalObject> global = Handle<GlobalObject>::cast(holder);
313 Object* value = global->property_dictionary()->ValueAt(dictionary_entry()); 313 Object* value = global->property_dictionary()->ValueAt(dictionary_entry());
314 DCHECK(value->IsPropertyCell()); 314 DCHECK(value->IsPropertyCell());
315 return Handle<PropertyCell>(PropertyCell::cast(value)); 315 return handle(PropertyCell::cast(value));
316 } 316 }
317 317
318 318
319 Handle<Object> LookupIterator::GetAccessors() const { 319 Handle<Object> LookupIterator::GetAccessors() const {
320 DCHECK_EQ(ACCESSOR, state_); 320 DCHECK_EQ(ACCESSOR, state_);
321 return FetchValue(); 321 return FetchValue();
322 } 322 }
323 323
324 324
325 Handle<Object> LookupIterator::GetDataValue() const { 325 Handle<Object> LookupIterator::GetDataValue() const {
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
386 // Fall through. 386 // Fall through.
387 case InterceptorState::kSkipNonMasking: 387 case InterceptorState::kSkipNonMasking:
388 return true; 388 return true;
389 case InterceptorState::kProcessNonMasking: 389 case InterceptorState::kProcessNonMasking:
390 return false; 390 return false;
391 } 391 }
392 } 392 }
393 return interceptor_state_ == InterceptorState::kProcessNonMasking; 393 return interceptor_state_ == InterceptorState::kProcessNonMasking;
394 } 394 }
395 } } // namespace v8::internal 395 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/lookup.h ('k') | src/unique.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698