Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: src/bootstrapper.cc

Issue 1022943002: Cannot use Handle<T>::cast in Unique<T>::cast since it will try to do a T::cast (and its typecheck)… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Locally allow handle deref Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/lookup.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/bootstrapper.h" 5 #include "src/bootstrapper.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/api-natives.h" 8 #include "src/api-natives.h"
9 #include "src/code-stubs.h" 9 #include "src/code-stubs.h"
10 #include "src/extensions/externalize-string-extension.h" 10 #include "src/extensions/externalize-string-extension.h"
(...skipping 2754 matching lines...) Expand 10 before | Expand all | Expand 10 after
2765 // If the property is already there we skip it. 2765 // If the property is already there we skip it.
2766 Handle<Name> key(Name::cast(raw_key)); 2766 Handle<Name> key(Name::cast(raw_key));
2767 LookupIterator it(to, key, LookupIterator::OWN_SKIP_INTERCEPTOR); 2767 LookupIterator it(to, key, LookupIterator::OWN_SKIP_INTERCEPTOR);
2768 CHECK_NE(LookupIterator::ACCESS_CHECK, it.state()); 2768 CHECK_NE(LookupIterator::ACCESS_CHECK, it.state());
2769 if (it.IsFound()) continue; 2769 if (it.IsFound()) continue;
2770 // Set the property. 2770 // Set the property.
2771 Handle<Object> value = Handle<Object>(properties->ValueAt(i), 2771 Handle<Object> value = Handle<Object>(properties->ValueAt(i),
2772 isolate()); 2772 isolate());
2773 DCHECK(!value->IsCell()); 2773 DCHECK(!value->IsCell());
2774 if (value->IsPropertyCell()) { 2774 if (value->IsPropertyCell()) {
2775 value = Handle<Object>(PropertyCell::cast(*value)->value(), 2775 value = handle(PropertyCell::cast(*value)->value(), isolate());
2776 isolate());
2777 } 2776 }
2778 PropertyDetails details = properties->DetailsAt(i); 2777 PropertyDetails details = properties->DetailsAt(i);
2779 DCHECK_EQ(kData, details.kind()); 2778 DCHECK_EQ(kData, details.kind());
2780 JSObject::AddProperty(to, key, value, details.attributes()); 2779 JSObject::AddProperty(to, key, value, details.attributes());
2781 } 2780 }
2782 } 2781 }
2783 } 2782 }
2784 } 2783 }
2785 2784
2786 2785
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
2964 return from + sizeof(NestingCounterType); 2963 return from + sizeof(NestingCounterType);
2965 } 2964 }
2966 2965
2967 2966
2968 // Called when the top-level V8 mutex is destroyed. 2967 // Called when the top-level V8 mutex is destroyed.
2969 void Bootstrapper::FreeThreadResources() { 2968 void Bootstrapper::FreeThreadResources() {
2970 DCHECK(!IsActive()); 2969 DCHECK(!IsActive());
2971 } 2970 }
2972 2971
2973 } } // namespace v8::internal 2972 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/lookup.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698