src/lookup.cc - Issue 1022943002: Cannot use Handle<T>::cast in Unique<T>::cast since it will try to do a T::cast (and its typecheck)…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/lookup.cc

Issue 1022943002: Cannot use Handle<T>::cast in Unique<T>::cast since it will try to do a T::cast (and its typecheck)… (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Locally allow handle deref Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/lookup.cc

diff --git a/src/lookup.cc b/src/lookup.cc

index 2b69aa67959f957a0fc283a6b4d30892257ec081..929b022ed5faa5b14ff5b8d536a60e21d612d101 100644

--- a/src/lookup.cc

+++ b/src/lookup.cc

@@ -312,7 +312,7 @@ Handle<PropertyCell> LookupIterator::GetPropertyCell() const {

Handle<GlobalObject> global = Handle<GlobalObject>::cast(holder);

Object* value = global->property_dictionary()->ValueAt(dictionary_entry());

DCHECK(value->IsPropertyCell());

- return Handle<PropertyCell>(PropertyCell::cast(value));

+ return handle(PropertyCell::cast(value));

}

« no previous file with comments | « src/lookup.h ('k') | src/unique.h » ('j') | no next file with comments »