DevTools: remove InspectorTest.assert from inspector-protocol tests

DevTools: remove InspectorTest.assert from inspector-protocol tests

BUG=468195
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192160

[yurys, 2015-03-18 15:36:55]

Patchset #1 (id:1) has been deleted

[yurys, 2015-03-18 15:37:16]

yurys@chromium.org changed reviewers:
+ alph@chromium.org, caseq@chromium.org, pfeldman@chromium.org

[alph, 2015-03-18 15:45:56]

What's the point of doing this?

Previously if the test failed it wrote a error message.
Now this is not that clear -- one might just go and accept an update to the
expectations without diving into details.

https://codereview.chromium.org/1021543002/diff/20001/LayoutTests/inspector-p...
File LayoutTests/inspector-protocol/console/console-timestamp.html (right):

https://codereview.chromium.org/1021543002/diff/20001/LayoutTests/inspector-p...
LayoutTests/inspector-protocol/console/console-timestamp.html:16:
InspectorTest.log("Message " + messages.length + " has non-decreasing timestamp:
" + (payload.timestamp >= messages[messages.length - 1].timestamp));
How does it work?
Previously it only spammed the log when the timestamps order was wrong. Now it
does it all the time.

[yurys, 2015-03-18 16:13:04]

The rationale is described in the bug. Basically we can always see if the output
differs from the expectations with no additional efforts in the code of the
test.

On 2015/03/18 15:45:56, alph wrote:
> What's the point of doing this?
> 
> Previously if the test failed it wrote a error message.
> Now this is not that clear -- one might just go and accept an update to the
> expectations without diving into details.
> 
>
https://codereview.chromium.org/1021543002/diff/20001/LayoutTests/inspector-p...
> File LayoutTests/inspector-protocol/console/console-timestamp.html (right):
> 
>
https://codereview.chromium.org/1021543002/diff/20001/LayoutTests/inspector-p...
> LayoutTests/inspector-protocol/console/console-timestamp.html:16:
> InspectorTest.log("Message " + messages.length + " has non-decreasing
timestamp:
> " + (payload.timestamp >= messages[messages.length - 1].timestamp));
> How does it work?
> Previously it only spammed the log when the timestamps order was wrong. Now it
> does it all the time.

[yurys, 2015-03-18 16:13:44]

https://codereview.chromium.org/1021543002/diff/20001/LayoutTests/inspector-p...
File LayoutTests/inspector-protocol/console/console-timestamp.html (right):

https://codereview.chromium.org/1021543002/diff/20001/LayoutTests/inspector-p...
LayoutTests/inspector-protocol/console/console-timestamp.html:16:
InspectorTest.log("Message " + messages.length + " has non-decreasing timestamp:
" + (payload.timestamp >= messages[messages.length - 1].timestamp));
On 2015/03/18 15:45:55, alph wrote:
> How does it work?
> Previously it only spammed the log when the timestamps order was wrong. Now it
> does it all the time.

Correct, and if there is a mismatch it is clear which part is failing.

[pfeldman, 2015-03-19 10:38:20]

lgtm

[yurys, 2015-03-19 10:52:04]

The CQ bit was checked by yurys@chromium.org

[commit-bot: I haz the power, 2015-03-19 10:52:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1021543002/20001

[commit-bot: I haz the power, 2015-03-19 12:33:25]

Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192160