Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: LayoutTests/inspector-protocol/layers/paint-profiler.html

Issue 1021543002: DevTools: remove InspectorTest.assert from inspector-protocol tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/inspector-protocol/layers/paint-profiler.html
diff --git a/LayoutTests/inspector-protocol/layers/paint-profiler.html b/LayoutTests/inspector-protocol/layers/paint-profiler.html
index 8d79b3cafb3df03987c39248e9f73171ae5ee458..e636ebcd16f8bdd6c29e414c742d5420f347a78e 100644
--- a/LayoutTests/inspector-protocol/layers/paint-profiler.html
+++ b/LayoutTests/inspector-protocol/layers/paint-profiler.html
@@ -26,7 +26,7 @@ function test()
function gotLayerTree(layers)
{
var matchingLayers = layers.filter(function(layer) { return !!(layer.backendNodeId && layer.transform); });
- InspectorTest.assertEquals(1, matchingLayers.length);
+ InspectorTest.log("matchingLayers.length: " + matchingLayers.length);
var layerId = matchingLayers[0].layerId;
InspectorTest.sendCommand("LayerTree.makeSnapshot", {"layerId": layerId}, InspectorTest.wrapCallback(gotSnapshot));
@@ -40,17 +40,17 @@ function test()
function gotProfile(result)
{
var timings = result.timings;
- InspectorTest.assertEquals(4, result.timings.length, "invalid profile array length");
+ InspectorTest.log("Profile array length: " + result.timings.length);
for (var i = 0; i < result.timings.length; ++i) {
- InspectorTest.assertEquals(result.timings[0].length, result.timings[i].length, "invalid profile subarray length");
+ InspectorTest.log("Profile subarray " + i + " length: " + result.timings[i].length);
for (var j = 0; j < result.timings[i].length; ++j)
- InspectorTest.assert(result.timings[i][j] >= 0, "profile timing is not a number");
+ InspectorTest.log("Profile timing [" + i + "][" + j + "] is a number: " + (result.timings[i][j] >= 0));
}
InspectorTest.sendCommand("LayerTree.replaySnapshot", {"snapshotId": snapshotId, "fromStep": 2, "toStep": result.timings[0].length - 2}, InspectorTest.wrapCallback(replayedSnapshot));
}
function replayedSnapshot(result)
{
- InspectorTest.assert(/^data:image\/png;base64,/, "invalid image returned from LayerTree.replaySnapshot");
+ InspectorTest.log("LayerTree.replaySnapshot returned valid image: " + /^data:image\/png;base64,/.test(result.dataURL));
InspectorTest.log("DONE!");
InspectorTest.completeTest();
}

Powered by Google App Engine
This is Rietveld 408576698