Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: LayoutTests/inspector-protocol/console/console-timestamp.html

Issue 1021543002: DevTools: remove InspectorTest.assert from inspector-protocol tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/inspector-protocol/console/console-timestamp.html
diff --git a/LayoutTests/inspector-protocol/console/console-timestamp.html b/LayoutTests/inspector-protocol/console/console-timestamp.html
index c1c1763826887d8208b8e2863d300975c31b865f..1d957267d1af841c16307094a64fa96da9c85bcc 100644
--- a/LayoutTests/inspector-protocol/console/console-timestamp.html
+++ b/LayoutTests/inspector-protocol/console/console-timestamp.html
@@ -13,12 +13,12 @@ function test()
var payload = data.params.message;
if (messages.length > 0)
- InspectorTest.assert(payload.timestamp >= messages[messages.length - 1].timestamp, "Timestamp shouldn't decrease over time.");
+ InspectorTest.log("Message " + messages.length + " has non-decreasing timestamp: " + (payload.timestamp >= messages[messages.length - 1].timestamp));
alph 2015/03/18 15:45:55 How does it work? Previously it only spammed the l
yurys 2015/03/18 16:13:43 Correct, and if there is a mismatch it is clear wh
messages.push(payload);
- InspectorTest.assert(payload.timestamp, "No timestamp found in message.");
+ InspectorTest.log("Message has timestamp: " + !!payload.timestamp);
- InspectorTest.assert(Math.abs(new Date().getTime() / 1000 - payload.timestamp) < 60, "Timestamp shouldn't differ very much from current time (one minute interval).");
+ InspectorTest.log("Message timestamp doesn't differ too much from current time (one minute interval): " + (Math.abs(new Date().getTime() / 1000 - payload.timestamp) < 60));
if (messages.length === 3)
InspectorTest.completeTest();
}

Powered by Google App Engine
This is Rietveld 408576698