Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: LayoutTests/inspector-protocol/timeline/timeline-layout.html

Issue 1021543002: DevTools: remove InspectorTest.assert from inspector-protocol tests (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/inspector-protocol/timeline/timeline-layout.html
diff --git a/LayoutTests/inspector-protocol/timeline/timeline-layout.html b/LayoutTests/inspector-protocol/timeline/timeline-layout.html
index b033b3de37f863414dadc3d953bcfcafe4959a79..1d8f520819efad2eb0a0ec46a0d8595864f4b430 100644
--- a/LayoutTests/inspector-protocol/timeline/timeline-layout.html
+++ b/LayoutTests/inspector-protocol/timeline/timeline-layout.html
@@ -27,23 +27,23 @@ function test()
var schedRecalc = InspectorTest.findEvent("ScheduleStyleRecalculation", "I");
var recalcBegin = InspectorTest.findEvent("RecalculateStyles", "B");
var recalcEnd = InspectorTest.findEvent("RecalculateStyles", "E");
- InspectorTest.assertEquals(schedRecalc.args.data.frame, recalcBegin.args.beginData.frame, "RecalculateStyles frame");
- InspectorTest.assert(recalcEnd.args.elementCount > 0, "RecalculateStyles elementCount");
+ InspectorTest.log("RecalculateStyles frames match: " + (schedRecalc.args.data.frame === recalcBegin.args.beginData.frame));
+ InspectorTest.log("RecalculateStyles elementCount > 0: " + (recalcEnd.args.elementCount > 0));
var invalidate = InspectorTest.findEvent("InvalidateLayout", "I");
var layoutBegin = InspectorTest.findEvent("Layout", "B");
var layoutEnd = InspectorTest.findEvent("Layout", "E");
- InspectorTest.assertEquals(recalcBegin.args.beginData.frame, invalidate.args.data.frame, "InvalidateLayout frame");
+ InspectorTest.log("InvalidateLayout frames match: " + (recalcBegin.args.beginData.frame === invalidate.args.data.frame));
var beginData = layoutBegin.args.beginData;
- InspectorTest.assertEquals(invalidate.args.data.frame, beginData.frame, "Layout frame");
- InspectorTest.assert(beginData.dirtyObjects > 0, "dirtyObjects");
- InspectorTest.assert(beginData.totalObjects > 0, "totalObjects");
+ InspectorTest.log("Layout frames match: " + (invalidate.args.data.frame === beginData.frame));
+ InspectorTest.log("dirtyObjects > 0: " + (beginData.dirtyObjects > 0));
+ InspectorTest.log("totalObjects > 0: " + (beginData.totalObjects > 0));
var endData = layoutEnd.args.endData;
- InspectorTest.assert(endData.rootNode > 0, "rootNode id");
- InspectorTest.assert(!!endData.root , "root quad");
+ InspectorTest.log("has rootNode id: " + (endData.rootNode > 0));
+ InspectorTest.log("has root quad: " + !!endData.root);
InspectorTest.log("SUCCESS: found all expected events.");
InspectorTest.completeTest();

Powered by Google App Engine
This is Rietveld 408576698