Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1021183002: [turbofan] Turn Math.clz32 into an inlinable builtin. (Closed)

Created:
5 years, 9 months ago by Benedikt Meurer
Modified:
5 years, 9 months ago
Reviewers:
dcarney, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Turn Math.clz32 into an inlinable builtin. R=dcarney@chromium.org, yangguo@chromium.org BUG=v8:3952 LOG=n Committed: https://crrev.com/3aa206b86560da94f895625186295bf07a0301d8 Cr-Commit-Position: refs/heads/master@{#27329}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -47 lines) Patch
M src/compiler/arm/code-generator-arm.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-codes-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-codes-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/counters.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/math.js View 2 chunks +4 lines, -12 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-maths.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -7 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-x64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A test/mjsunit/asm/math-clz32.js View 1 chunk +31 lines, -0 lines 0 comments Download
M test/unittests/compiler/arm/instruction-selector-arm-unittest.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M test/unittests/compiler/ia32/instruction-selector-ia32-unittest.cc View 2 chunks +18 lines, -3 lines 0 comments Download
M test/unittests/compiler/js-intrinsic-lowering-unittest.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M test/unittests/compiler/machine-operator-unittest.cc View 1 chunk +18 lines, -18 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler/x64/instruction-selector-x64-unittest.cc View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Benedikt Meurer
5 years, 9 months ago (2015-03-20 08:01:37 UTC) #1
Benedikt Meurer
Yang: Please take a look at the general math changes. Dan: Please review the TurboFan ...
5 years, 9 months ago (2015-03-20 08:02:32 UTC) #3
dcarney
lgtm
5 years, 9 months ago (2015-03-20 08:12:06 UTC) #4
Yang
On 2015/03/20 08:12:06, dcarney wrote: > lgtm lgtm. Though I'm not sure whether we actually ...
5 years, 9 months ago (2015-03-20 08:33:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1021183002/1
5 years, 9 months ago (2015-03-20 08:36:38 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 08:37:46 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3aa206b86560da94f895625186295bf07a0301d8
Cr-Commit-Position: refs/heads/master@{#27329}

Powered by Google App Engine
This is Rietveld 408576698