Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 1019563002: Load from PropertyCells using PropertyCell::kValueOffset rather than Cell::kValueOffset (Closed)

Created:
5 years, 9 months ago by Toon Verwaest
Modified:
5 years, 9 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Load from PropertyCells using PropertyCell::kValueOffset rather than Cell::kValueOffset BUG= Committed: https://crrev.com/dda2bd6f4f952c604ab836f04052684722480849 Cr-Commit-Position: refs/heads/master@{#27280}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M src/ic/arm/handler-compiler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
PTAL
5 years, 9 months ago (2015-03-18 17:17:31 UTC) #2
dcarney
lgtm
5 years, 9 months ago (2015-03-18 17:22:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1019563002/1
5 years, 9 months ago (2015-03-18 17:22:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-18 19:53:42 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 19:54:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dda2bd6f4f952c604ab836f04052684722480849
Cr-Commit-Position: refs/heads/master@{#27280}

Powered by Google App Engine
This is Rietveld 408576698