Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: src/ic/arm/handler-compiler-arm.cc

Issue 1019563002: Load from PropertyCells using PropertyCell::kValueOffset rather than Cell::kValueOffset (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/ic/arm64/handler-compiler-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/ic/call-optimization.h" 9 #include "src/ic/call-optimization.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
(...skipping 710 matching lines...) Expand 10 before | Expand all | Expand 10 after
721 Label miss; 721 Label miss;
722 if (IC::ICUseVector(kind())) { 722 if (IC::ICUseVector(kind())) {
723 PushVectorAndSlot(); 723 PushVectorAndSlot();
724 } 724 }
725 FrontendHeader(receiver(), name, &miss); 725 FrontendHeader(receiver(), name, &miss);
726 726
727 // Get the value from the cell. 727 // Get the value from the cell.
728 Register result = StoreDescriptor::ValueRegister(); 728 Register result = StoreDescriptor::ValueRegister();
729 Handle<WeakCell> weak_cell = factory()->NewWeakCell(cell); 729 Handle<WeakCell> weak_cell = factory()->NewWeakCell(cell);
730 __ LoadWeakValue(result, weak_cell, &miss); 730 __ LoadWeakValue(result, weak_cell, &miss);
731 __ ldr(result, FieldMemOperand(result, Cell::kValueOffset)); 731 __ ldr(result, FieldMemOperand(result, PropertyCell::kValueOffset));
732 732
733 // Check for deleted property if property can actually be deleted. 733 // Check for deleted property if property can actually be deleted.
734 if (is_configurable) { 734 if (is_configurable) {
735 __ LoadRoot(ip, Heap::kTheHoleValueRootIndex); 735 __ LoadRoot(ip, Heap::kTheHoleValueRootIndex);
736 __ cmp(result, ip); 736 __ cmp(result, ip);
737 __ b(eq, &miss); 737 __ b(eq, &miss);
738 } 738 }
739 739
740 Counters* counters = isolate()->counters(); 740 Counters* counters = isolate()->counters();
741 __ IncrementCounter(counters->named_load_global_stub(), 1, r1, r3); 741 __ IncrementCounter(counters->named_load_global_stub(), 1, r1, r3);
742 if (IC::ICUseVector(kind())) { 742 if (IC::ICUseVector(kind())) {
743 DiscardVectorAndSlot(); 743 DiscardVectorAndSlot();
744 } 744 }
745 __ Ret(); 745 __ Ret();
746 746
747 FrontendFooter(name, &miss); 747 FrontendFooter(name, &miss);
748 748
749 // Return the generated code. 749 // Return the generated code.
750 return GetCode(kind(), Code::NORMAL, name); 750 return GetCode(kind(), Code::NORMAL, name);
751 } 751 }
752 752
753 753
754 #undef __ 754 #undef __
755 } 755 }
756 } // namespace v8::internal 756 } // namespace v8::internal
757 757
758 #endif // V8_TARGET_ARCH_ARM 758 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/ic/arm64/handler-compiler-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698