Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: src/ic/x64/handler-compiler-x64.cc

Issue 1019563002: Load from PropertyCells using PropertyCell::kValueOffset rather than Cell::kValueOffset (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ic/arm64/handler-compiler-arm64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X64 7 #if V8_TARGET_ARCH_X64
8 8
9 #include "src/ic/call-optimization.h" 9 #include "src/ic/call-optimization.h"
10 #include "src/ic/handler-compiler.h" 10 #include "src/ic/handler-compiler.h"
(...skipping 191 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 202
203 203
204 void PropertyHandlerCompiler::GenerateCheckPropertyCell( 204 void PropertyHandlerCompiler::GenerateCheckPropertyCell(
205 MacroAssembler* masm, Handle<JSGlobalObject> global, Handle<Name> name, 205 MacroAssembler* masm, Handle<JSGlobalObject> global, Handle<Name> name,
206 Register scratch, Label* miss) { 206 Register scratch, Label* miss) {
207 Handle<PropertyCell> cell = JSGlobalObject::EnsurePropertyCell(global, name); 207 Handle<PropertyCell> cell = JSGlobalObject::EnsurePropertyCell(global, name);
208 DCHECK(cell->value()->IsTheHole()); 208 DCHECK(cell->value()->IsTheHole());
209 Factory* factory = masm->isolate()->factory(); 209 Factory* factory = masm->isolate()->factory();
210 Handle<WeakCell> weak_cell = factory->NewWeakCell(cell); 210 Handle<WeakCell> weak_cell = factory->NewWeakCell(cell);
211 __ LoadWeakValue(scratch, weak_cell, miss); 211 __ LoadWeakValue(scratch, weak_cell, miss);
212 __ Cmp(FieldOperand(scratch, Cell::kValueOffset), factory->the_hole_value()); 212 __ Cmp(FieldOperand(scratch, PropertyCell::kValueOffset),
213 factory->the_hole_value());
213 __ j(not_equal, miss); 214 __ j(not_equal, miss);
214 } 215 }
215 216
216 217
217 void NamedStoreHandlerCompiler::GenerateStoreViaSetter( 218 void NamedStoreHandlerCompiler::GenerateStoreViaSetter(
218 MacroAssembler* masm, Handle<Map> map, Register receiver, Register holder, 219 MacroAssembler* masm, Handle<Map> map, Register receiver, Register holder,
219 int accessor_index, int expected_arguments, Register scratch) { 220 int accessor_index, int expected_arguments, Register scratch) {
220 // ----------- S t a t e ------------- 221 // ----------- S t a t e -------------
221 // -- rsp[0] : return address 222 // -- rsp[0] : return address
222 // ----------------------------------- 223 // -----------------------------------
(...skipping 537 matching lines...) Expand 10 before | Expand all | Expand 10 after
760 // Return the generated code. 761 // Return the generated code.
761 return GetCode(kind(), Code::NORMAL, name); 762 return GetCode(kind(), Code::NORMAL, name);
762 } 763 }
763 764
764 765
765 #undef __ 766 #undef __
766 } 767 }
767 } // namespace v8::internal 768 } // namespace v8::internal
768 769
769 #endif // V8_TARGET_ARCH_X64 770 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ic/arm64/handler-compiler-arm64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698