src/ic/x64/handler-compiler-x64.cc - Issue 1019563002: Load from PropertyCells using PropertyCell::kValueOffset rather than Cell::kValueOffset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/x64/handler-compiler-x64.cc

Issue 1019563002: Load from PropertyCells using PropertyCell::kValueOffset rather than Cell::kValueOffset (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ic/x64/handler-compiler-x64.cc

diff --git a/src/ic/x64/handler-compiler-x64.cc b/src/ic/x64/handler-compiler-x64.cc

index 23882dcb5cb8e743828a4813eb8e201e00b6484a..b6add9d2bc1469ec421706c39ffe7bf7b2dcf08f 100644

--- a/src/ic/x64/handler-compiler-x64.cc

+++ b/src/ic/x64/handler-compiler-x64.cc

@@ -209,7 +209,8 @@ void PropertyHandlerCompiler::GenerateCheckPropertyCell(

Factory* factory = masm->isolate()->factory();

Handle<WeakCell> weak_cell = factory->NewWeakCell(cell);

__ LoadWeakValue(scratch, weak_cell, miss);

- __ Cmp(FieldOperand(scratch, Cell::kValueOffset), factory->the_hole_value());

+ __ Cmp(FieldOperand(scratch, PropertyCell::kValueOffset),

+ factory->the_hole_value());

__ j(not_equal, miss);

}

« no previous file with comments | « src/ic/arm64/handler-compiler-arm64.cc ('k') | no next file » | no next file with comments »