Fix some problems reported by clang static analyzer

Fix some problems reported by clang static analyzer

These changes fix code paths where variable writes are done that have no effect later on, or code paths that do nothing.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164628

[rwlbuis, 2014-01-06 23:11:53]

This patch fixes some issues pointed out by the clang static analyzer. I guess
some of variable writes made sense at some point but refactorings must have made
them unnecessary.

[pdr., 2014-01-07 21:31:54]

On 2014/01/06 23:11:53, rwlbuis wrote:
> This patch fixes some issues pointed out by the clang static analyzer. I guess
> some of variable writes made sense at some point but refactorings must have
made
> them unnecessary.

LGTM, I think this is a useful cleanup.

If it's not too long, could you list the command you ran in the change
description? I imagine others might want to try this in the future.

[rwlbuis, 2014-01-07 21:48:40]

On 2014/01/07 21:31:54, pdr wrote:
> On 2014/01/06 23:11:53, rwlbuis wrote:
> > This patch fixes some issues pointed out by the clang static analyzer. I
guess
> > some of variable writes made sense at some point but refactorings must have
> made
> > them unnecessary.
> 
> LGTM, I think this is a useful cleanup.
> 
> If it's not too long, could you list the command you ran in the change
> description? I imagine others might want to try this in the future.

Thanks!
It is a bit complex actually, so I won't put it in the change. However there are
instructions on the web for using ninja and scan-build/the clang static
analyzer.

[commit-bot: I haz the power, 2014-01-07 21:49:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/101763008/1

[commit-bot: I haz the power, 2014-01-07 23:30:32]

Change committed as 164628