Source/core/rendering/InlineTextBox.cpp - Issue 101763008: Fix some problems reported by clang static analyzer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/InlineTextBox.cpp

Issue 101763008: Fix some problems reported by clang static analyzer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/InlineTextBox.cpp

diff --git a/Source/core/rendering/InlineTextBox.cpp b/Source/core/rendering/InlineTextBox.cpp

index 60a35deccf1253ac5df7bbcae293e5ccc1ae2019..27948545287d9763242e1c69a427cd870093470c 100644

--- a/Source/core/rendering/InlineTextBox.cpp

+++ b/Source/core/rendering/InlineTextBox.cpp

@@ -211,8 +211,6 @@ LayoutRect InlineTextBox::localSelectionRect(int startPos, int endPos)

StringBuilder charactersWithHyphen;

bool respectHyphen = ePos == m_len && hasHyphen();

TextRun textRun = constructTextRun(styleToUse, font, respectHyphen ? &charactersWithHyphen : 0);

- if (respectHyphen)

- endPos = textRun.length();

FloatPoint startingPoint = FloatPoint(logicalLeft(), selTop);

LayoutRect r;

« no previous file with comments | « Source/core/rendering/CompositedLayerMapping.cpp ('k') | Source/core/rendering/RenderBlockLineLayout.cpp » ('j') | no next file with comments »